Re: [PATCH] t1503: test rev-parse --verify --quiet with deleted reflogs

2014-09-15 Thread Junio C Hamano
David Aguilar writes: >> > +test_expect_success 'fails silently when using -q with deleted reflogs' ' >> > + ref=$(git rev-parse HEAD) && >> > + : >.git/logs/refs/test && >> > + git update-ref -m test refs/test "$ref" && >> >> I'm just curious, why not simply >> >>git branch test >> ? >

Re: [PATCH] t1503: test rev-parse --verify --quiet with deleted reflogs

2014-09-15 Thread Junio C Hamano
David Aguilar writes: > Good point. The --quiet spec doesn't say anything about stdout, Please correct it while at it in the doc ;-) I think I had to look it up in the documentation and then in code if git rev-parse --verify --quiet "$object" the right way to check if the object is a good

Re: [PATCH] t1503: test rev-parse --verify --quiet with deleted reflogs

2014-09-14 Thread David Aguilar
On Sun, Sep 14, 2014 at 06:20:57PM +0200, Fabian Ruch wrote: > Hi David, > > On 09/14/2014 10:30 AM, David Aguilar wrote: > > Ensure that rev-parse --verify --quiet is silent when asked > > about deleted reflog entries. > > > > Signed-off-by: David Aguilar > > --- > > This verifies and depends o

Re: [PATCH] t1503: test rev-parse --verify --quiet with deleted reflogs

2014-09-14 Thread Fabian Ruch
Hi David, On 09/14/2014 10:30 AM, David Aguilar wrote: > Ensure that rev-parse --verify --quiet is silent when asked > about deleted reflog entries. > > Signed-off-by: David Aguilar > --- > This verifies and depends on "refs: make rev-parse --quiet actually quiet". > > t/t1503-rev-parse-verify

[PATCH] t1503: test rev-parse --verify --quiet with deleted reflogs

2014-09-14 Thread David Aguilar
Ensure that rev-parse --verify --quiet is silent when asked about deleted reflog entries. Signed-off-by: David Aguilar --- This verifies and depends on "refs: make rev-parse --quiet actually quiet". t/t1503-rev-parse-verify.sh | 9 + 1 file changed, 9 insertions(+) diff --git a/t/t1503