Re: [PATCH] t0090: mark add-interactive test with PERL prerequisite

2014-11-18 Thread Pete Wyckoff
jrnie...@gmail.com wrote on Tue, 18 Nov 2014 10:43 -0800: > ... and here's a patch on top to give git-p4 the same treatment. > > -- >8 -- > Subject: Makefile: have python scripts depend on NO_PYTHON setting > > Like the perl scripts, python scripts need a dependency to ensure they > are rebuilt w

Re: [PATCH] t0090: mark add-interactive test with PERL prerequisite

2014-11-18 Thread Jonathan Nieder
Jeff King wrote: > The add-interactive system is built in perl. If you build > with NO_PERL, running "git commit --interactive" will exit > with an error and the test will fail. > > Signed-off-by: Jeff King > --- > Noticed by Michael while working around gitweb failures by setting > NO_PERL. :)

Re: [PATCH] t0090: mark add-interactive test with PERL prerequisite

2014-11-18 Thread Jeff King
On Tue, Nov 18, 2014 at 10:43:47AM -0800, Jonathan Nieder wrote: > ... and here's a patch on top to give git-p4 the same treatment. > > -- >8 -- > Subject: Makefile: have python scripts depend on NO_PYTHON setting > > Like the perl scripts, python scripts need a dependency to ensure they > are r

Re: [PATCH] t0090: mark add-interactive test with PERL prerequisite

2014-11-18 Thread Jeff King
On Tue, Nov 18, 2014 at 10:38:38AM -0800, Jonathan Nieder wrote: > Reviewed-by: Jonathan Nieder Thanks. > > +# This makes sure we depend on the NO_PERL setting itself. > > +$(patsubst %.perl,%,$(SCRIPT_PERL)): GIT-BUILD-OPTIONS > > + > > ifndef NO_PERL > > $(patsubst %.perl,%,$(SCRIPT_PERL)):

Re: [PATCH] t0090: mark add-interactive test with PERL prerequisite

2014-11-18 Thread Jonathan Nieder
Jonathan Nieder wrote: > Jeff King wrote: >> Subject: Makefile: have perl scripts depend on NO_PERL setting > [...] >> --- >> Makefile | 3 +++ >> 1 file changed, 3 insertions(+) > > Gah. Good catch. > > Reviewed-by: Jonathan Nieder ... and here's a patch on top to give git-p4 the same treatme

Re: [PATCH] t0090: mark add-interactive test with PERL prerequisite

2014-11-18 Thread Jonathan Nieder
Jeff King wrote: > Subject: Makefile: have perl scripts depend on NO_PERL setting [...] > --- > Makefile | 3 +++ > 1 file changed, 3 insertions(+) Gah. Good catch. Reviewed-by: Jonathan Nieder [...] > --- a/Makefile > +++ b/Makefile > @@ -1676,6 +1676,9 @@ git.res: git.rc GIT-VERSION-FILE >

Re: [PATCH] t0090: mark add-interactive test with PERL prerequisite

2014-11-18 Thread Jeff King
On Tue, Nov 18, 2014 at 12:22:31PM -0500, Jeff King wrote: > The add-interactive system is built in perl. If you build > with NO_PERL, running "git commit --interactive" will exit > with an error and the test will fail. > > Signed-off-by: Jeff King > --- > Noticed by Michael while working around

[PATCH] t0090: mark add-interactive test with PERL prerequisite

2014-11-18 Thread Jeff King
The add-interactive system is built in perl. If you build with NO_PERL, running "git commit --interactive" will exit with an error and the test will fail. Signed-off-by: Jeff King --- Noticed by Michael while working around gitweb failures by setting NO_PERL. :) It didn't reproduce for me in my