Re: [PATCH] t: don't redefine test_config() in various places

2013-03-20 Thread Ramkumar Ramachandra
Junio C Hamano wrote: > Ramkumar Ramachandra writes: > >> test_config() is already a well-defined function in >> test-lib-functions.sh. Don't duplicate it unnecessarily in: >> >> t4018-diff-funcname.sh >> t7810-grep.sh >> t7811-grep-open.sh >> >> Signed-off-by: Ramkumar Ramachandra >> ---

Re: [PATCH] t: don't redefine test_config() in various places

2013-03-20 Thread Junio C Hamano
Ramkumar Ramachandra writes: > test_config() is already a well-defined function in > test-lib-functions.sh. Don't duplicate it unnecessarily in: > > t4018-diff-funcname.sh > t7810-grep.sh > t7811-grep-open.sh > > Signed-off-by: Ramkumar Ramachandra > --- > Thanks, Junio. Heh, I've pushe

Re: [PATCH] t: don't redefine test_config() in various places

2013-03-20 Thread Jonathan Nieder
Ramkumar Ramachandra wrote: > Signed-off-by: Ramkumar Ramachandra > --- > Thanks, Junio. > > t/t4018-diff-funcname.sh | 5 - > t/t7810-grep.sh | 5 - > t/t7811-grep-open.sh | 5 - > 3 files changed, 15 deletions(-) Yeah, that looks like all of them. FWIW, Reviewed-by:

[PATCH] t: don't redefine test_config() in various places

2013-03-20 Thread Ramkumar Ramachandra
test_config() is already a well-defined function in test-lib-functions.sh. Don't duplicate it unnecessarily in: t4018-diff-funcname.sh t7810-grep.sh t7811-grep-open.sh Signed-off-by: Ramkumar Ramachandra --- Thanks, Junio. t/t4018-diff-funcname.sh | 5 - t/t7810-grep.sh |