Re: [PATCH] t/README: test_must_fail is for testing Git

2013-06-04 Thread Philip Oakley
From: "Junio C Hamano" Sent: Tuesday, June 04, 2013 9:49 PM "Philip Oakley" writes: From: "Junio C Hamano" Sent: Tuesday, June 04, 2013 5:50 PM When a test wants to make sure there is no in an output file, we should just say "! grep string output"; Small nit: It took me two readings of t

Re: [PATCH] t/README: test_must_fail is for testing Git

2013-06-04 Thread Junio C Hamano
"Philip Oakley" writes: > From: "Junio C Hamano" > Sent: Tuesday, June 04, 2013 5:50 PM >> When a test wants to make sure there is no in an output >> file, we should just say "! grep string output"; > > Small nit: It took me two readings of the commit message to correctly > parse this break poi

Re: [PATCH] t/README: test_must_fail is for testing Git

2013-06-04 Thread Philip Oakley
From: "Junio C Hamano" Sent: Tuesday, June 04, 2013 5:50 PM When a test wants to make sure there is no in an output file, we should just say "! grep string output"; Small nit: It took me two readings of the commit message to correctly parse this break point. The flowing together of the two p

[PATCH] t/README: test_must_fail is for testing Git

2013-06-04 Thread Junio C Hamano
When a test wants to make sure there is no in an output file, we should just say "! grep string output"; "test_must_fail" is there only to test Git command and catch unusual deaths we know about (e.g. segv) as an error, not as an expected failure. Signed-off-by: Junio C Hamano --- t/README | 3