Re: [PATCH] submodule foreach: correct $sm_path in nested submodules from a dir

2017-06-05 Thread Jonathan Nieder
Hi, This patch seems to aim to do multiple things. Initial thoughts: Stefan Beller wrote: [...] > To ameliorate the situation, perform these changes > * Document 'sm_path' instead of 'path'. > As using a variable '$path' may be harmful to users due to > capitalization issues, see 64394e3ae9

Re: [PATCH] submodule foreach: correct $sm_path in nested submodules from a dir

2017-06-04 Thread Ramsay Jones
On 03/06/17 15:07, Ramsay Jones wrote: [snip] >> diff --git a/Documentation/git-submodule.txt >> b/Documentation/git-submodule.txt >> index 74bc6200d5..52e3ef1325 100644 >> --- a/Documentation/git-submodule.txt >> +++ b/Documentation/git-submodule.txt >> @@ -218,20 +218,24 @@ information too. >

Re: [PATCH] submodule foreach: correct $sm_path in nested submodules from a dir

2017-06-03 Thread Ramsay Jones
On 03/06/17 01:37, Stefan Beller wrote: > When running 'git submodule foreach' from a subdirectory of your > repository, nested submodules get a bogus value for $sm_path: > For a submodule 'sub' that contains a nested submodule 'nested', > running 'git -C dir submodule foreach echo $path' would r

[PATCH] submodule foreach: correct $sm_path in nested submodules from a dir

2017-06-02 Thread Stefan Beller
When running 'git submodule foreach' from a subdirectory of your repository, nested submodules get a bogus value for $sm_path: For a submodule 'sub' that contains a nested submodule 'nested', running 'git -C dir submodule foreach echo $path' would report path='../nested' for the nested submodule. T