Re: [PATCH] submodule-config: use hashmap_iter_init()

On Wed, Mar 16, 2016 at 1:08 AM, Stefan Beller wrote: > The change looks correct to me. But as Eric said, the commit message > needs work and a sign off. With that, > Reviewed-by: Stefan Beller Ah, yes, forgot to pass `-s` to commit command. Sorry for noise guys, will resend the patch. -- To uns

Re: [PATCH] submodule-config: use hashmap_iter_init()

On Tue, Mar 15, 2016 at 11:58 AM, Eric Sunshine wrote: > On Tue, Mar 15, 2016 at 2:25 PM, Alexander Kuleshov > wrote: >> submodule-config: use hashmap_iter_init() > > Did you mean s/init/first/ ? > >> from the for simplification. > > Sentence fragment... > > Missing sign-off. > >> --- >> diff --

Re: [PATCH] submodule-config: use hashmap_iter_init()

On Tue, Mar 15, 2016 at 2:25 PM, Alexander Kuleshov wrote: > submodule-config: use hashmap_iter_init() Did you mean s/init/first/ ? > from the for simplification. Sentence fragment... Missing sign-off. > --- > diff --git a/submodule-config.c b/submodule-config.c > index b82d1fb..8ac5031 1006

[PATCH] submodule-config: use hashmap_iter_init()

from the for simplification. --- submodule-config.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/submodule-config.c b/submodule-config.c index b82d1fb..8ac5031 100644 --- a/submodule-config.c +++ b/submodule-config.c @@ -405,8 +405,7 @@ static const struct submodule *conf