Stefan Beller writes:
> On Sat, Dec 10, 2016 at 5:41 AM, vi0oss wrote:
>> On 12/08/2016 04:38 AM, vi0...@gmail.com wrote:
>>>
>>> Third review: missing && in test fixed.
>>>
>>
>> Shall something more be done about this or just wait until the patch gets
>> reviewed and integrated?
>
> I hav
On Sat, Dec 10, 2016 at 5:41 AM, vi0oss wrote:
> On 12/08/2016 04:38 AM, vi0...@gmail.com wrote:
>>
>> Third review: missing && in test fixed.
>>
>
> Shall something more be done about this or just wait until the patch gets
> reviewed and integrated?
I have no further comments and think the
From: "Vitaly \"_Vi\" Shukela"
In 31224cbdc7 (clone: recursive and reference option triggers
submodule alternates, 2016-08-17) a mechanism was added to
have submodules referenced. It did not address _nested_
submodules, however.
This patch makes all not just the root repository, but also
all su
On 12/08/2016 04:38 AM, vi0...@gmail.com wrote:
Third review: missing && in test fixed.
Shall something more be done about this or just wait until the patch
gets reviewed and integrated?
On Thu, Dec 08, 2016 at 09:04:46PM +0300, vi0oss wrote:
> Why Git test use &&-chains instead of proper "set -e"?
Because "set -e" comes with all kinds of confusing corner cases. Using
&& chains is annoying, but rarely surprising.
One of my favorite examples is:
set -e
(
false
echo 1
On Thu, Dec 8, 2016 at 10:04 AM, vi0oss wrote:
> On 12/08/2016 08:46 PM, Jeff King wrote:
>>
>> On Wed, Dec 07, 2016 at 05:22:30PM -0800, Stefan Beller wrote:
>>
>>> On Wed, Dec 7, 2016 at 4:39 PM, wrote:
>>>
Previously test contained errorneous
test_must_fail, which was mask
On 12/08/2016 08:46 PM, Jeff King wrote:
On Wed, Dec 07, 2016 at 05:22:30PM -0800, Stefan Beller wrote:
On Wed, Dec 7, 2016 at 4:39 PM, wrote:
Previously test contained errorneous
test_must_fail, which was masked by
missing &&.
I wonder if we could make either
the test_must_
On Thu, Dec 8, 2016 at 9:46 AM, Jeff King wrote:
>
> will both trigger on the &&-chain linter, because it uses a magic exit
> code to detect the breakage. I think the problem is just that the
> &&-chain linter cannot peek inside subshells, and that's where the bug
> was in this case.
Uh, yeah in
On Wed, Dec 07, 2016 at 05:22:30PM -0800, Stefan Beller wrote:
> On Wed, Dec 7, 2016 at 4:39 PM, wrote:
>
> >
> > Previously test contained errorneous
> > test_must_fail, which was masked by
> > missing &&.
>
> I wonder if we could make either
> the test_must_fail intelligent to de
From: "Vitaly \"_Vi\" Shukela"
In 31224cbdc7 (clone: recursive and reference option triggers
submodule alternates, 2016-08-17) a mechanism was added to
have submodules referenced. It did not address _nested_
submodules, however.
This patch makes all not just the root repository, but also
all su
On Wed, Dec 7, 2016 at 4:39 PM, wrote:
>
> Previously test contained errorneous
> test_must_fail, which was masked by
> missing &&.
I wonder if we could make either
the test_must_fail intelligent to detect such a broken && call chain
or the test_expect_success macro to see for those
From: "Vitaly \"_Vi\" Shukela"
In 31224cbdc7 (clone: recursive and reference option triggers
submodule alternates, 2016-08-17) a mechanism was added to
have submodules referenced. It did not address _nested_
submodules, however.
This patch makes all not just the root repository, but also
all su
On Wed, Dec 7, 2016 at 1:24 PM, vi0oss wrote:
> On 12/07/2016 11:09 PM, Stefan Beller wrote:
>>>
>>> As submodule's alternate target does not end in .git/objects
>>> (rather .git/modules/qq/objects), this alternate target
>>> path restriction for in add_possible_reference_from_superproject
>>>
On 12/07/2016 11:09 PM, Stefan Beller wrote:
As submodule's alternate target does not end in .git/objects
(rather .git/modules/qq/objects), this alternate target
path restriction for in add_possible_reference_from_superproject
relates from "*.git/objects" to just */objects".
I wonder if this
Stefan Beller writes:
> On Wed, Dec 7, 2016 at 12:18 PM, Junio C Hamano wrote:
>> Stefan Beller writes:
>>
This patch makes all not just the root repository, but also
all submodules (recursively) have submodule.alternateLocation
and submodule.alternateErrorStrategy configured, ma
On Wed, Dec 7, 2016 at 12:18 PM, Junio C Hamano wrote:
> Stefan Beller writes:
>
>>> This patch makes all not just the root repository, but also
>>> all submodules (recursively) have submodule.alternateLocation
>>> and submodule.alternateErrorStrategy configured, making Git
>>> search for possibl
Stefan Beller writes:
>> This patch makes all not just the root repository, but also
>> all submodules (recursively) have submodule.alternateLocation
>> and submodule.alternateErrorStrategy configured, making Git
>> search for possible alternates for nested submodules as well.
>
> Sounds great!
On Wed, Dec 7, 2016 at 10:42 AM, wrote:
> From: Vitaly _Vi Shukela
Thanks for contributing to Git!
(/me looks up if you have sent patches already as you
seem to know how to do that. :) unrelated side note: Maybe you want
to send a patch for the .mailmap file mapping your two email addresses
tog
From: Vitaly _Vi Shukela
Git v2.11 introduced "git clone --recursive --referece ...",
but it didn't put the alternates for _nested_ submodules.
This patch makes all not just the root repository, but also
all submodules (recursively) have submodule.alternateLocation
and submodule.alternateErrorSt
19 matches
Mail list logo
