Re: [PATCH] specify encoding for sed command

2018-04-12 Thread Matthew Coleman
>> I think the best way to move forward with this is a new patch that uses >> `awk` instead of `sed`: I tested several `awk` variants and the command >> was portable without requiring any changes to LANG or LC_ALL. >> >> Does that sound like a good plan? > > No ;) > Could you please give the patc

Re: [PATCH] specify encoding for sed command

2018-04-12 Thread SZEDER Gábor
> I did a little more digging into this issue today. > The issue isn't actually caused by `sed`: it's caused by the way that > the `set` builtin outputs characters in the Unicode Private Use Area > (PUA) in the build of Bash 3.2.57 that macOS Sierra ships with. > > Powerline uses several PUA cod

Re: [PATCH] specify encoding for sed command

2018-04-12 Thread Matthew Coleman
I did a little more digging into this issue today. > On Apr 11, 2018, at 4:42 PM, Matt Coleman wrote: > > I found another (possibly better) way to fix this: > >> On Apr 10, 2018, at 3:18 AM, Matt Coleman wrote: >> >>> 1) What platform OS / version / sed version is this on? >> I'm experiencing

Re: [PATCH] specify encoding for sed command

2018-04-11 Thread Matt Coleman
I found another (possibly better) way to fix this: > On Apr 10, 2018, at 3:18 AM, Matt Coleman wrote: > >> 1) What platform OS / version / sed version is this on? > I'm experiencing this on macOS Sierra (10.12.6). The issue occurs with the > OS's native sed, which is FreeBSD sed so the version

Re: [PATCH] specify encoding for sed command

2018-04-10 Thread Matt Coleman
> 1) What platform OS / version / sed version is this on? I'm experiencing this on macOS Sierra (10.12.6). The issue occurs with the OS's native sed, which is FreeBSD sed so the version number is kind of ambiguous. The error goes away if I set LANG=C or LC_ALL=C or change it to use GNU sed (inst

Re: [PATCH] specify encoding for sed command

2018-04-08 Thread Junio C Hamano
Stephon Harris writes: > Fixes issue with seeing `sed: RE error: illegal byte sequence` when running > git-completion.bash > --- > contrib/completion/git-completion.bash | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/completion/git-completion.bash > b/contrib/

Re: [PATCH] specify encoding for sed command

2018-04-05 Thread SZEDER Gábor
On Thu, Apr 5, 2018 at 8:53 AM, Ævar Arnfjörð Bjarmason wrote: > > On Thu, Apr 05 2018, Stephon Harris wrote: > >> Fixes issue with seeing `sed: RE error: illegal byte sequence` when running >> git-completion.bash Please: - prefix the subject line with "completion:". - nit: replace "running"

Re: [PATCH] specify encoding for sed command

2018-04-05 Thread Eric Sunshine
On Thu, Apr 5, 2018 at 2:53 AM, Ævar Arnfjörð Bjarmason wrote: > On Thu, Apr 05 2018, Stephon Harris wrote: >> Fixes issue with seeing `sed: RE error: illegal byte sequence` when running >> git-completion.bash > > This is getting closer to the issue than your previous patch, but > there's still s

Re: [PATCH] specify encoding for sed command

2018-04-04 Thread Ævar Arnfjörð Bjarmason
On Thu, Apr 05 2018, Stephon Harris wrote: > Fixes issue with seeing `sed: RE error: illegal byte sequence` when running > git-completion.bash > --- > contrib/completion/git-completion.bash | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/completion/git-completio

[PATCH] specify encoding for sed command

2018-04-04 Thread Stephon Harris
Fixes issue with seeing `sed: RE error: illegal byte sequence` when running git-completion.bash --- contrib/completion/git-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index b09