Re: [PATCH] show-ref: place angle brackets around variables in usage string

2015-08-31 Thread Junio C Hamano
Junio C Hamano writes: >>> - N_("git show-ref --exclude-existing[=pattern] < ref-list"), >>> + N_("git show-ref --exclude-existing[=] < "), >> >> Should the '<' stdin redirection be shown? > > Hmm, that actually is an interesting thought,... Having said all that (i.e. I agree dropping "< $anythi

Re: [PATCH] show-ref: place angle brackets around variables in usage string

2015-08-31 Thread Junio C Hamano
"Philip Oakley" writes: > From: "Alex Henrie" >> Signed-off-by: Alex Henrie >> --- >> builtin/show-ref.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/builtin/show-ref.c b/builtin/show-ref.c >> index dfbc314..131ef28 100644 >> --- a/builtin/show-ref.c >> +++ b/built

Re: [PATCH] show-ref: place angle brackets around variables in usage string

2015-08-29 Thread Alex Henrie
2015-08-29 4:21 GMT-06:00 Philip Oakley : > Should the '<' stdin redirection be shown? > > It looks (at first glance) as if this gained a double '< <' at the beginning > of 'ref-list', rather than being a clean indication of the redirection. > Perhaps change 'ref-list' to 'ref-list-file' for a slig

Re: [PATCH] show-ref: place angle brackets around variables in usage string

2015-08-29 Thread Philip Oakley
From: "Alex Henrie" Signed-off-by: Alex Henrie --- builtin/show-ref.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/show-ref.c b/builtin/show-ref.c index dfbc314..131ef28 100644 --- a/builtin/show-ref.c +++ b/builtin/show-ref.c @@ -8,7 +8,7 @@ static const char * c

[PATCH] show-ref: place angle brackets around variables in usage string

2015-08-28 Thread Alex Henrie
Signed-off-by: Alex Henrie --- builtin/show-ref.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/show-ref.c b/builtin/show-ref.c index dfbc314..131ef28 100644 --- a/builtin/show-ref.c +++ b/builtin/show-ref.c @@ -8,7 +8,7 @@ static const char * const show_ref_usage