Re: [PATCH] show-branch: show all local heads when only giving one rev along --topics

2015-03-30 Thread Mike Hommey
On Mon, Mar 30, 2015 at 03:24:26PM -0700, Junio C Hamano wrote: > Mike Hommey writes: > > > (Maybe --topics should always require one rev on the command > > line?) > > That sounds line a good thing to do. > > > - else if (all_heads + all_remotes) > > - snarf_refs(all_heads, all_remo

Re: [PATCH] show-branch: show all local heads when only giving one rev along --topics

2015-03-30 Thread Junio C Hamano
Junio C Hamano writes: > ...? I am not saying the change > is problematic; it is just I haven't looked at this code for a long > time that the existing machinery is already designed to tolerate > duplicated input. "for a long time to say that the existing code is OK or not" is what I meant to s

Re: [PATCH] show-branch: show all local heads when only giving one rev along --topics

2015-03-30 Thread Junio C Hamano
Mike Hommey writes: > (Maybe --topics should always require one rev on the command > line?) That sounds line a good thing to do. > - else if (all_heads + all_remotes) > - snarf_refs(all_heads, all_remotes); > else { > while (0 < ac) { >

[PATCH] show-branch: show all local heads when only giving one rev along --topics

2015-03-30 Thread Mike Hommey
"git show-branch --topics ..." displays ancestry graph, only considering commits that are in all given revs, except the first one. "git show-branch" displays ancestry graph for all local branches. Unfortunately, "git show-branch --topics " only prints out the rev info for the given rev, and noth

Re: [PATCH] show-branch: show all local heads when only giving one rev along --topics

2015-03-16 Thread Mike Hommey
On Mon, Mar 16, 2015 at 05:38:06PM +0900, Mike Hommey wrote: > "git show-branch --topics ..." displays ancestry graph, only > considering commits that are in all given revs, except the first one. > > "git show-branch" displays ancestry graph for all local branches. > > Unfortunately, "git show-b

[PATCH] show-branch: show all local heads when only giving one rev along --topics

2015-03-16 Thread Mike Hommey
"git show-branch --topics ..." displays ancestry graph, only considering commits that are in all given revs, except the first one. "git show-branch" displays ancestry graph for all local branches. Unfortunately, "git show-branch --topics " only prints out the rev info for the given rev, and noth