Re: [PATCH] sequencer: make sign_off_header a file local symbol

2019-02-11 Thread Junio C Hamano
Ramsay Jones writes: > This has been hanging around for a while. I sent it to the list last > time in [1], but it seems to have been dropped. (Found while attempting > to rebase loads of old branches to a newer base!) Thanks. Will apply.

[PATCH] sequencer: make sign_off_header a file local symbol

2019-02-11 Thread Ramsay Jones
Commit d0aaa46fd3 ("commit: move empty message checks to libgit", 2017-11-10) removes the last use of 'sign_off_header' outside of the "sequencer.c" source file. Remove the extern declaration from the header file and mark the definition of the symbol with the static keyword. Signed-off-by: Ramsa

[PATCH] sequencer: make sign_off_header a file local symbol

2017-12-09 Thread Ramsay Jones
Commit d0aaa46fd3 ("commit: move empty message checks to libgit", 2017-11-10) removes the last use of 'sign_off_header' outside of the "sequencer.c" source file. Remove the extern declaration from the header file and mark the definition of the symbol with the static keyword. Signed-off-by: Ramsay

Re: [PATCH] sequencer: make sign_off_header a file local symbol

2017-11-21 Thread Ramsay Jones
On 21/11/17 01:06, Junio C Hamano wrote: > Ramsay Jones writes: > >> Signed-off-by: Ramsay Jones >> --- >> >> Hi Miklos, >> >> If you need to re-roll your 'mv/cherry-pick-s' branch, could you >> please squash this into the relevant patch (commit 5ed75e2a3f, >> "cherry-pick: don't forget -s on

Re: [PATCH] sequencer: make sign_off_header a file local symbol

2017-11-20 Thread Junio C Hamano
Junio C Hamano writes: > Ramsay Jones writes: > >> Signed-off-by: Ramsay Jones >> --- >> >> Hi Miklos, >> >> If you need to re-roll your 'mv/cherry-pick-s' branch, could you >> please squash this into the relevant patch (commit 5ed75e2a3f, >> "cherry-pick: don't forget -s on failure", 14-09-201

Re: [PATCH] sequencer: make sign_off_header a file local symbol

2017-11-20 Thread Junio C Hamano
Ramsay Jones writes: > Signed-off-by: Ramsay Jones > --- > > Hi Miklos, > > If you need to re-roll your 'mv/cherry-pick-s' branch, could you > please squash this into the relevant patch (commit 5ed75e2a3f, > "cherry-pick: don't forget -s on failure", 14-09-2017). What automated procedure are yo

[PATCH] sequencer: make sign_off_header a file local symbol

2017-11-20 Thread Ramsay Jones
Signed-off-by: Ramsay Jones --- Hi Miklos, If you need to re-roll your 'mv/cherry-pick-s' branch, could you please squash this into the relevant patch (commit 5ed75e2a3f, "cherry-pick: don't forget -s on failure", 14-09-2017). [noticed by sparse]. Thanks! ATB, Ramsay Jones sequencer.c | 2