Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Ævar Arnfjörð Bjarmason
On Tue, May 28 2019, brian m. carlson wrote: > On 2019-05-27 at 20:36:36, Ævar Arnfjörð Bjarmason wrote: >> I've done enough git-send-email patching in anger for a year at least >> with what's sitting in "next" so I'm not working on this, but just my >> 0.02: >> >> I wonder if we shouldn't just

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Eric Wong
Ævar Arnfjörð Bjarmason wrote: > On Tue, May 28 2019, Eric Wong wrote: > > Todd Zullinger wrote: > >> Something like: > >> > >> diff --git i/git-send-email.perl w/git-send-email.perl > >> index 24859a7bc3..84ac03994d 100755 > >> --- i/git-send-email.perl > >> +++ w/git-send-email.perl > >> @@ -14

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Todd Zullinger
Hi, Sorry I missed your earlier reply which also mentioned using $obj->can() Ævar. That's what I get for typing a reply and then walking away for a few hours before hitting send. ;) Ævar Arnfjörð Bjarmason wrote: > Same, but to bikeshed a bit, at this point we can just do: > > diff --gi

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Ævar Arnfjörð Bjarmason
On Tue, May 28 2019, Eric Wong wrote: > Todd Zullinger wrote: >> I wonder if it's (separately from this change) worth >> adjusting the conditional which sets $use_net_smtp_ssl to >> use "Net::SMTP->can('starttls')" rather than a strict >> version check? (It might not be if using 'can' is too >

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Eric Wong
Todd Zullinger wrote: > I wonder if it's (separately from this change) worth > adjusting the conditional which sets $use_net_smtp_ssl to > use "Net::SMTP->can('starttls')" rather than a strict > version check? (It might not be if using 'can' is too > fragile or would only benefit the Red Hat 7 pa

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Eric Wong
Ævar Arnfjörð Bjarmason wrote: > On Mon, May 27 2019, Eric Wong wrote: > > Chris Mayo wrote: > >> git-send-email uses the TLS support in the Net::SMTP core module from > >> recent versions of Perl. Documenting the minimum version is complex > >> because of separate numbering for Perl (5.21.5~169)

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Todd Zullinger
Eric Wong wrote: > Chris Mayo wrote: >> git-send-email uses the TLS support in the Net::SMTP core module from >> recent versions of Perl. Documenting the minimum version is complex >> because of separate numbering for Perl (5.21.5~169), Net:SMTP (2.34) >> and libnet (3.01). Version numbers from co

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread brian m. carlson
On 2019-05-27 at 20:36:36, Ævar Arnfjörð Bjarmason wrote: > I've done enough git-send-email patching in anger for a year at least > with what's sitting in "next" so I'm not working on this, but just my > 0.02: > > I wonder if we shouldn't just be much more aggressive about version > requirements f

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Ævar Arnfjörð Bjarmason
On Mon, May 27 2019, Eric Wong wrote: > Chris Mayo wrote: >> git-send-email uses the TLS support in the Net::SMTP core module from >> recent versions of Perl. Documenting the minimum version is complex >> because of separate numbering for Perl (5.21.5~169), Net:SMTP (2.34) >> and libnet (3.01).

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Eric Wong
Chris Mayo wrote: > git-send-email uses the TLS support in the Net::SMTP core module from > recent versions of Perl. Documenting the minimum version is complex > because of separate numbering for Perl (5.21.5~169), Net:SMTP (2.34) > and libnet (3.01). Version numbers from commit: > bfbfc9a953 ("se

[PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-26 Thread Chris Mayo
git-send-email uses the TLS support in the Net::SMTP core module from recent versions of Perl. Documenting the minimum version is complex because of separate numbering for Perl (5.21.5~169), Net:SMTP (2.34) and libnet (3.01). Version numbers from commit: bfbfc9a953 ("send-email: Net::SMTP::starttls