Re: [PATCH] send-email: don't call methods on undefined values

2013-09-12 Thread Junio C Hamano
"brian m. carlson" writes: > On Mon, Sep 09, 2013 at 09:45:10AM -0700, Junio C Hamano wrote: >> "brian m. carlson" writes: >> > --- a/git-send-email.perl >> > +++ b/git-send-email.perl >> > @@ -1234,7 +1234,7 @@ X-Mailer: git-send-email $gitversion >> >if ($smtp->code

Re: [PATCH] send-email: don't call methods on undefined values

2013-09-09 Thread brian m. carlson
On Mon, Sep 09, 2013 at 09:45:10AM -0700, Junio C Hamano wrote: > "brian m. carlson" writes: > > --- a/git-send-email.perl > > +++ b/git-send-email.perl > > @@ -1234,7 +1234,7 @@ X-Mailer: git-send-email $gitversion > > if ($smtp->code == 220) { > >

Re: [PATCH] send-email: don't call methods on undefined values

2013-09-09 Thread Junio C Hamano
"brian m. carlson" writes: > If SSL verification is enabled in git send-email, we could attempt to call a > method on an undefined value if the verification failed, since $smtp would end > up being undef. Look up the error string in a way that will produce a helpful > error message and not cause

[PATCH] send-email: don't call methods on undefined values

2013-09-08 Thread brian m. carlson
If SSL verification is enabled in git send-email, we could attempt to call a method on an undefined value if the verification failed, since $smtp would end up being undef. Look up the error string in a way that will produce a helpful error message and not cause further errors. Signed-off-by: bria