Re: [PATCH] run-command: report exec failure

2018-12-13 Thread Jeff King
On Wed, Dec 12, 2018 at 10:27:40AM -0500, John Passaro wrote: > Thank you for this incredibly quick fix. > > I see the fix made it to pu as 6b206be3e5 ("run-command: report exec > failure" 2018-12-11). For what it's worth, it fixes the issue as far > as I'm concerned and I'm very glad to see the

Re: [PATCH] run-command: report exec failure

2018-12-12 Thread John Passaro
Thank you for this incredibly quick fix. I see the fix made it to pu as 6b206be3e5 ("run-command: report exec failure" 2018-12-11). For what it's worth, it fixes the issue as far as I'm concerned and I'm very glad to see the behavior is covered by tests now. As a procedural question: I'd like to

Re: [PATCH] run-command: report exec failure

2018-12-11 Thread Junio C Hamano
Johannes Schindelin writes: > This breaks on Windows (on Windows, the error message says "cannot spawn", see Thanks for a quick feedback. Let's update to look for the pathname of the command, as Peff suggested earlier.

Re: [PATCH] run-command: report exec failure

2018-12-11 Thread Johannes Schindelin
Hi Junio, On Tue, 11 Dec 2018, Junio C Hamano wrote: > diff --git a/t/t0061-run-command.sh b/t/t0061-run-command.sh > index cf932c8514..9c83d44d9c 100755 > --- a/t/t0061-run-command.sh > +++ b/t/t0061-run-command.sh > @@ -13,11 +13,13 @@ cat >hello-script <<-EOF > EOF > > test_expect_success

Re: [PATCH] run-command: report exec failure

2018-12-11 Thread Jeff King
On Tue, Dec 11, 2018 at 02:46:07PM +0900, Junio C Hamano wrote: > In 321fd823 ("run-command: mark path lookup errors with ENOENT", > 2018-10-24), we rewrote the logic to execute a command by looking > in the directories on $PATH; as a side effect, a request to run a > command that is not found on

[PATCH] run-command: report exec failure

2018-12-10 Thread Junio C Hamano
In 321fd823 ("run-command: mark path lookup errors with ENOENT", 2018-10-24), we rewrote the logic to execute a command by looking in the directories on $PATH; as a side effect, a request to run a command that is not found on $PATH is noticed even before a child process is forked to execute it. We