Re: [PATCH] rewrite finish_bulk_checkin() using strbuf

2014-03-01 Thread Faiz Kothari
On Sat, Mar 1, 2014 at 4:33 PM, He Sun wrote: > 2014-03-01 15:18 GMT+08:00 Faiz Kothari : >> Hi, >> Yup, at that position. >> I don't know, but it failed a few tests on my machine related to bitmap. >> Another thing to use would be strbuf_splice() > > Eric Sunshine has came up with a more > elegan

Re: [PATCH] rewrite finish_bulk_checkin() using strbuf

2014-03-01 Thread He Sun
2014-03-01 15:18 GMT+08:00 Faiz Kothari : > Hi, > Yup, at that position. > I don't know, but it failed a few tests on my machine related to bitmap. > Another thing to use would be strbuf_splice() Eric Sunshine has came up with a more elegant way to finish this task. That's using strbuf_setlen() in

Re: [PATCH] rewrite finish_bulk_checkin() using strbuf

2014-02-28 Thread He Sun
2014-03-01 14:46 GMT+08:00 Faiz Kothari : > From: Faiz Kotahri > > Signed-off-by: Faiz Kothari > --- > Sticking with implementation involving changing the prototype for > pack-write.c:finish_tmp_packfile() > Fixing a small bug in Sun He's implementation which caused a fail in some > tests. > >

Re: [PATCH] rewrite finish_bulk_checkin() using strbuf

2014-02-28 Thread He Sun
2014-03-01 14:46 GMT+08:00 Faiz Kothari : > From: Faiz Kotahri > > Signed-off-by: Faiz Kothari > --- > Sticking with implementation involving changing the prototype for > pack-write.c:finish_tmp_packfile() > Fixing a small bug in Sun He's implementation which caused a fail in some > tests. > >

[PATCH] rewrite finish_bulk_checkin() using strbuf

2014-02-28 Thread Faiz Kothari
From: Faiz Kotahri Signed-off-by: Faiz Kothari --- Sticking with implementation involving changing the prototype for pack-write.c:finish_tmp_packfile() Fixing a small bug in Sun He's implementation which caused a fail in some tests. builtin/pack-objects.c | 25 - bulk