Re: [PATCH] revision.c: reduce object database queries

2018-02-28 Thread Derrick Stolee
On 2/28/2018 1:37 AM, Jeff King wrote: On Tue, Feb 27, 2018 at 03:16:58PM -0800, Junio C Hamano wrote: This code comes originally form 454fbbcde3 (git-rev-list: allow missing objects when the parent is marked UNINTERESTING, 2005-07-10). But later, in aeeae1b771 (revision traversal: allow UNINTE

Re: [PATCH] revision.c: reduce object database queries

2018-02-27 Thread Jeff King
On Tue, Feb 27, 2018 at 03:16:58PM -0800, Junio C Hamano wrote: > >> This code comes originally form 454fbbcde3 (git-rev-list: allow missing > >> objects when the parent is marked UNINTERESTING, 2005-07-10). But later, > >> in aeeae1b771 (revision traversal: allow UNINTERESTING objects to be > >>

Re: [PATCH] revision.c: reduce object database queries

2018-02-27 Thread Junio C Hamano
Jeff King writes: >> This code comes originally form 454fbbcde3 (git-rev-list: allow missing >> objects when the parent is marked UNINTERESTING, 2005-07-10). But later, >> in aeeae1b771 (revision traversal: allow UNINTERESTING objects to be >> missing, 2009-01-27), we marked dealt with calling pa

Re: [PATCH] revision.c: reduce object database queries

2018-02-25 Thread Jeff King
On Sun, Feb 25, 2018 at 08:30:48PM -0500, Jeff King wrote: > > diff --git a/revision.c b/revision.c > > index 5ce9b93..bc7def5 100644 > > --- a/revision.c > > +++ b/revision.c > > @@ -113,7 +113,8 @@ void mark_parents_uninteresting(struct commit *commit) > > * it is popped nex

Re: [PATCH] revision.c: reduce object database queries

2018-02-25 Thread Jeff King
On Sat, Feb 24, 2018 at 08:34:56PM -0500, Derrick Stolee wrote: > In mark_parents_uninteresting(), we check for the existence of an > object file to see if we should treat a commit as parsed. The result > is to set the "parsed" bit on the commit. > > Modify the condition to only check has_object_

Re: [PATCH] revision.c: reduce object database queries

2018-02-24 Thread Derrick Stolee
On 2/24/2018 8:34 PM, Derrick Stolee wrote: In mark_parents_uninteresting(), we check for the existence of an object file to see if we should treat a commit as parsed. The result is to set the "parsed" bit on the commit. Modify the condition to only check has_object_file() if the result would ch

[PATCH] revision.c: reduce object database queries

2018-02-24 Thread Derrick Stolee
In mark_parents_uninteresting(), we check for the existence of an object file to see if we should treat a commit as parsed. The result is to set the "parsed" bit on the commit. Modify the condition to only check has_object_file() if the result would change the parsed bit. When a local branch is d