Re: [PATCH] revision: add --reflog-message to grep reflog messages

2012-09-27 Thread Junio C Hamano
Jeff King writes: > I actually think just checking the reflog when we call "--grep" would > the most common workflow, and requires no extra work from the user. My > only hesitation is that if somebody _does_ want to distinguish, there's > no escape hatch. Of course, the reflog walker is already

Re: [PATCH] revision: add --reflog-message to grep reflog messages

2012-09-27 Thread Jeff King
On Thu, Sep 27, 2012 at 10:09:28AM -0700, Junio C Hamano wrote: > > +--reflog-message=:: > > + Limit the commits output to ones with reflog entries that > > + match the specified pattern (regular expression). Ignored unless > > + --walk-reflogs is given. > > + > > I am debating myself if it

Re: [PATCH] revision: add --reflog-message to grep reflog messages

2012-09-27 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Signed-off-by: Nguyễn Thái Ngọc Duy > --- Plase explain yourself in the space above. > diff --git a/Documentation/rev-list-options.txt > b/Documentation/rev-list-options.txt > index 1fc2a18..aeaa58c 100644 > --- a/Documentation/rev-list-options.txt > +++ b/Docum

[PATCH] revision: add --reflog-message to grep reflog messages

2012-09-27 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- On Thu, Sep 27, 2012 at 2:28 AM, Junio C Hamano wrote: > The current commit_match() runs grep_buffer() on commit->buffer. It > probably makes sense to instead notice from opt that we are running > log with "-g", prepare a temporary strbuf and add in t

Re: [PATCH] revision: add --reflog-message= to grep reflog messages

2012-09-26 Thread Junio C Hamano
Nguyen Thai Ngoc Duy writes: > On Wed, Sep 26, 2012 at 9:07 PM, Junio C Hamano wrote: >> Nguyễn Thái Ngọc Duy writes: >> >>> Both "git log" and "git reflog show" recognize this option. >>> >>> Signed-off-by: Nguyễn Thái Ngọc Duy >>> --- >> >> How well does it interact with --grep and/or --all

Re: [PATCH] revision: add --reflog-message= to grep reflog messages

2012-09-26 Thread Nguyen Thai Ngoc Duy
On Wed, Sep 26, 2012 at 9:07 PM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> Both "git log" and "git reflog show" recognize this option. >> >> Signed-off-by: Nguyễn Thái Ngọc Duy >> --- > > How well does it interact with --grep and/or --all-match? Good point. It currently works l

Re: [PATCH] revision: add --reflog-message= to grep reflog messages

2012-09-26 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Both "git log" and "git reflog show" recognize this option. > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- How well does it interact with --grep and/or --all-match? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majo

[PATCH] revision: add --reflog-message= to grep reflog messages

2012-09-26 Thread Nguyễn Thái Ngọc Duy
Both "git log" and "git reflog show" recognize this option. Signed-off-by: Nguyễn Thái Ngọc Duy --- Itch: how to show reflogs for checkout operation only? Instead of ignoring when -g is not given, we might want to imply -g. Still itch: grep highlight! For all applicable areas: commit headers