Re: [PATCH] rev-parse doc: clarify use of optional / required arguments

2013-10-15 Thread Nicolas Vigier
On Mon, 14 Oct 2013, brian m. carlson wrote: > On Mon, Oct 14, 2013 at 05:25:29PM +0200, Nicolas Vigier wrote: > > The reason that I looked at this documentation in the first place was > > that I was looking at adding an option '-S[], --gpg-sign[=]' > > to git-rebase, similar to the option in git-

Re: [PATCH] rev-parse doc: clarify use of optional / required arguments

2013-10-14 Thread brian m. carlson
On Mon, Oct 14, 2013 at 05:25:29PM +0200, Nicolas Vigier wrote: > The reason that I looked at this documentation in the first place was > that I was looking at adding an option '-S[], --gpg-sign[=]' > to git-rebase, similar to the option in git-commit, so that rebased > commits can be signed. In gi

Re: [PATCH] rev-parse doc: clarify use of optional / required arguments

2013-10-14 Thread Nicolas Vigier
On Mon, 14 Oct 2013, Jonathan Nieder wrote: > Nicolas Vigier wrote: > > > "the option is optional" was confusing as it is not the option but its > > argument which is optional. > > > > Signed-off-by: Nicolas Vigier > > Thanks. > > [...] > > --- a/Documentation/git-rev-parse.txt > > +++ b/Docum

Re: [PATCH] rev-parse doc: clarify use of optional / required arguments

2013-10-14 Thread Jonathan Nieder
Nicolas Vigier wrote: > "the option is optional" was confusing as it is not the option but its > argument which is optional. > > Signed-off-by: Nicolas Vigier Thanks. [...] > --- a/Documentation/git-rev-parse.txt > +++ b/Documentation/git-rev-parse.txt > @@ -259,9 +259,10 @@ Each line of option

[PATCH] rev-parse doc: clarify use of optional / required arguments

2013-10-14 Thread Nicolas Vigier
"the option is optional" was confusing as it is not the option but its argument which is optional. Signed-off-by: Nicolas Vigier --- Documentation/git-rev-parse.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/git-rev-parse.txt b/Documentation/git-rev-pa