Re: [PATCH] rebase --preserve-merges keeps empty merge commits

2013-02-24 Thread Junio C Hamano
Martin von Zweigbergk writes: > I'm working on a re-roll of > > http://thread.gmane.org/gmane.comp.version-control.git/205796 > > and finally got around to including test cases for what you fixed in > this patch. I want to make sure I'm testing what you fixed here. See > questions below. Did any

Re: [PATCH] rebase --preserve-merges keeps empty merge commits

2013-02-02 Thread Martin von Zweigbergk
On Fri, Feb 1, 2013 at 1:05 PM, Phil Hord wrote: > > This is probably right, but it is not exactly the case that caused my itch. > I think my branch looked like [...] That also makes sense. I'll add tests for both cases. Your patch makes both of them pass. >> # a---b---c >> # \ \ >> #

Re: [PATCH] rebase --preserve-merges keeps empty merge commits

2013-02-01 Thread Phil Hord
Martin von Zweigbergk wrote: > I'm working on a re-roll of > http://thread.gmane.org/gmane.comp.version-control.git/205796 > > and finally got around to including test cases for what you fixed in > this patch. I want to make sure I'm testing what you fixed here. See > questions below. Thanks for

Re: [PATCH] rebase --preserve-merges keeps empty merge commits

2013-02-01 Thread Martin von Zweigbergk
I'm working on a re-roll of http://thread.gmane.org/gmane.comp.version-control.git/205796 and finally got around to including test cases for what you fixed in this patch. I want to make sure I'm testing what you fixed here. See questions below. On Sat, Jan 12, 2013 at 12:46 PM, Phil Hord wrote:

Re: [PATCH] rebase --preserve-merges keeps empty merge commits

2013-01-14 Thread Phil Hord
Junio C Hamano wrote: > Matthieu Moy writes: > >> Phil Hord writes: >> >>> Subject: [PATCH] rebase --preserve-merges keeps empty merge commits >> I would rephrase it as >> >> rebase --preserve-merges: keep empty merge commits >> >> w

Re: [PATCH] rebase --preserve-merges keeps empty merge commits

2013-01-14 Thread Junio C Hamano
Matthieu Moy writes: > Phil Hord writes: > >> Subject: [PATCH] rebase --preserve-merges keeps empty merge commits > > I would rephrase it as > > rebase --preserve-merges: keep empty merge commits > > we usually give orders in commit messages, not state fa

Re: [PATCH] rebase --preserve-merges keeps empty merge commits

2013-01-14 Thread Matthieu Moy
Phil Hord writes: > Subject: [PATCH] rebase --preserve-merges keeps empty merge commits I would rephrase it as rebase --preserve-merges: keep empty merge commits we usually give orders in commit messages, not state facts (it's not clear from the existing subject line whether keepi

Re: [PATCH] rebase --preserve-merges keeps empty merge commits

2013-01-14 Thread Neil Horman
On Sat, Jan 12, 2013 at 03:46:01PM -0500, Phil Hord wrote: > Since 90e1818f9a (git-rebase: add keep_empty flag, 2012-04-20) > 'git rebase --preserve-merges' fails to preserve empty merge commits > unless --keep-empty is also specified. Merge commits should be > preserved in order to preserve the

[PATCH] rebase --preserve-merges keeps empty merge commits

2013-01-12 Thread Phil Hord
Since 90e1818f9a (git-rebase: add keep_empty flag, 2012-04-20) 'git rebase --preserve-merges' fails to preserve empty merge commits unless --keep-empty is also specified. Merge commits should be preserved in order to preserve the structure of the rebased graph, even if the merge commit does not i