Re: [PATCH] rebase-i: loosen over-eager check_bad_cmd check

2015-09-30 Thread Eric Sunshine
On Wed, Sep 30, 2015 at 4:01 PM, Matthieu Moy wrote: > 804098bb (git rebase -i: add static check for commands and SHA-1, > 2015-06-29) tried to check all insns before running any in the todo > list, but it did so by implementing its own parser that is a lot > stricter than necessary. We used to a

[PATCH] rebase-i: loosen over-eager check_bad_cmd check

2015-09-30 Thread Matthieu Moy
804098bb (git rebase -i: add static check for commands and SHA-1, 2015-06-29) tried to check all insns before running any in the todo list, but it did so by implementing its own parser that is a lot stricter than necessary. We used to allow lines that are indented (including comment lines), and we