Re: [PATCH] rebase: return non-zero error code if format-patch fails

Clemens Buchacher writes: > On Fri, Jul 03, 2015 at 10:52:32AM -0700, Junio C Hamano wrote: >> > >> > Cc: Andrew Wong >> > Signed-off-by: Clemens Buchacher >> > Reviewed-by: Jorge Nunes >> >> Where was this review made? I may have missed a recent discussion, >> and that is why I am asking, b

Re: [PATCH] rebase: return non-zero error code if format-patch fails

On Fri, Jul 03, 2015 at 10:52:32AM -0700, Junio C Hamano wrote: > > > > Cc: Andrew Wong > > Signed-off-by: Clemens Buchacher > > Reviewed-by: Jorge Nunes > > Where was this review made? I may have missed a recent discussion, > and that is why I am asking, because Reviewed-by: lines that cannot

Re: [PATCH] rebase: return non-zero error code if format-patch fails

Clemens Buchacher writes: > Since e481af06 (rebase: Handle cases where format-patch fails) we > notice if format-patch fails and return immediately from > git-rebase--am. We save the return value with ret=$?, but then we > return $?, which is usually zero in this case. > > Fix this by returning $

[PATCH] rebase: return non-zero error code if format-patch fails

Since e481af06 (rebase: Handle cases where format-patch fails) we notice if format-patch fails and return immediately from git-rebase--am. We save the return value with ret=$?, but then we return $?, which is usually zero in this case. Fix this by returning $ret instead. Cc: Andrew Wong Signed-o