Re: [PATCH] read_index_from: remove bogus errno assignments

Nguyễn Thái Ngọc Duy writes: > While at it, move die_errno() next to xmmap() call because it's the > mmap's error code that we care about. Otherwise if close(fd); fails, > it could overwrite mmap's errno. Makes sense and is a sensible fix. Thanks. -- To unsubscribe from this list: send the line

[PATCH] read_index_from: remove bogus errno assignments

These assignments comes from the very first commit e83c516 (Initial revision of "git", the information manager from hell - 2005-04-07). Back then we did not die() when errors happened so correct errno was required. Since 5d1a5c0 ([PATCH] Better error reporting for "git status" - 2005-10-01), read_