Re: [PATCH] read-cache: fix division by zero core-dump

2018-10-01 Thread Derrick Stolee
On 9/28/2018 11:31 AM, Ramsay Jones wrote: Also, this is not the first time some multi-threaded code in git has 'failed' by assuming more than one cpu, so ... I wonder if this is a good time to create a GIT_TEST_CPU_COUNT variable so we can mock out single-processor environments instead of rely

Re: [PATCH] read-cache: fix division by zero core-dump

2018-09-28 Thread Ramsay Jones
On 28/09/18 02:20, Ben Peart wrote: > > > On 9/27/2018 6:24 PM, Ramsay Jones wrote: >> >> commit 225df8a468 ("ieot: add Index Entry Offset Table (IEOT) >> extension", 2018-09-26) added a 'DIV_ROUND_UP(entries, ieot_blocks) >> expression, where ieot_blocks was set to zero for a single cpu >> pl

Re: [PATCH] read-cache: fix division by zero core-dump

2018-09-27 Thread Ben Peart
On 9/27/2018 6:24 PM, Ramsay Jones wrote: commit 225df8a468 ("ieot: add Index Entry Offset Table (IEOT) extension", 2018-09-26) added a 'DIV_ROUND_UP(entries, ieot_blocks) expression, where ieot_blocks was set to zero for a single cpu platform. This caused an SIGFPE and a core dump in practic

[PATCH] read-cache: fix division by zero core-dump

2018-09-27 Thread Ramsay Jones
commit 225df8a468 ("ieot: add Index Entry Offset Table (IEOT) extension", 2018-09-26) added a 'DIV_ROUND_UP(entries, ieot_blocks) expression, where ieot_blocks was set to zero for a single cpu platform. This caused an SIGFPE and a core dump in practically every test in the test-suite, until test