Re: [PATCH] read-cache: call verify_hdr() in a background thread

2017-03-24 Thread Jonathan Nieder
Jeff Hostetler wrote: > On 3/24/2017 12:35 PM, Jonathan Nieder wrote: >> What happens if there is an error before the code reaches the end of >> the function? I think there needs to be a verify_hdr_finish call in >> the 'unmap:' cleanup section. > > But the "unmap" section calls die(). Do need t

Re: [PATCH] read-cache: call verify_hdr() in a background thread

2017-03-24 Thread Jeff Hostetler
On 3/24/2017 12:35 PM, Jonathan Nieder wrote: g...@jeffhostetler.com wrote: From: Jeff Hostetler Teash do_read_index() in read-cache.c to call verify_hdr() ... Nice. Do you have example commands I can run to reproduce that benchmark? (Even better if you can phrase that as a patch against

Re: [PATCH] read-cache: call verify_hdr() in a background thread

2017-03-24 Thread Jonathan Nieder
g...@jeffhostetler.com wrote: > From: Jeff Hostetler > > Teash do_read_index() in read-cache.c to call verify_hdr() s/Teash/Teach/ > in a background thread while the forground thread parses s/forground/foreground/ > the index and builds the_index. > > This is a performance optimization to red

Re: [PATCH] read-cache: call verify_hdr() in a background thread

2017-03-24 Thread Jeff Hostetler
On 3/24/2017 11:36 AM, Jeff King wrote: On Fri, Mar 24, 2017 at 01:27:51PM +, g...@jeffhostetler.com wrote: From: Jeff Hostetler Teash do_read_index() in read-cache.c to call verify_hdr() in a background thread while the forground thread parses the index and builds the_index. This is a

Re: [PATCH] read-cache: call verify_hdr() in a background thread

2017-03-24 Thread Jeff King
On Fri, Mar 24, 2017 at 01:27:51PM +, g...@jeffhostetler.com wrote: > From: Jeff Hostetler > > Teash do_read_index() in read-cache.c to call verify_hdr() > in a background thread while the forground thread parses > the index and builds the_index. > > This is a performance optimization to re

[PATCH] read-cache: call verify_hdr() in a background thread

2017-03-24 Thread git
From: Jeff Hostetler This patch contains a performance optimization to run verify_hdr() in a background thread while the foreground thread parses the index. This allows do_read_index() to complete faster. This idea was recently discussed on the mailing list in: https://public-inbox.org/git/8522

[PATCH] read-cache: call verify_hdr() in a background thread

2017-03-24 Thread git
From: Jeff Hostetler Teash do_read_index() in read-cache.c to call verify_hdr() in a background thread while the forground thread parses the index and builds the_index. This is a performance optimization to reduce the overall time required to get the index into memory. Testing on Windows (using