Re: [PATCH] range-diff: allow to diff files regardless submodule

2018-10-24 Thread Lucas De Marchi
On Wed, Oct 24, 2018 at 02:18:43PM +0900, Junio C Hamano wrote: > Junio C Hamano writes: > > > Lucas De Marchi writes: > > > >> Your reply arrived just a little after I sent the v2, so I thought it > >> was just the race and you would end up seeing the unread email in the > >> same thread. Sorry

Re: [PATCH] range-diff: allow to diff files regardless submodule

2018-10-23 Thread Junio C Hamano
Junio C Hamano writes: > Lucas De Marchi writes: > >> Your reply arrived just a little after I sent the v2, so I thought it >> was just the race and you would end up seeing the unread email in the >> same thread. Sorry for not including the msg id: >> 20181011081750.24240-1-lucas.demar...@intel.

Re: [PATCH] range-diff: allow to diff files regardless submodule

2018-10-23 Thread Junio C Hamano
Lucas De Marchi writes: > Your reply arrived just a little after I sent the v2, so I thought it > was just the race and you would end up seeing the unread email in the > same thread. Sorry for not including the msg id: > 20181011081750.24240-1-lucas.demar...@intel.com OK, then I am not surprised

Re: [PATCH] range-diff: allow to diff files regardless submodule

2018-10-23 Thread Lucas De Marchi
On Wed, Oct 24, 2018 at 11:12:51AM +0900, Junio C Hamano wrote: > Lucas De Marchi writes: > > >> Yes, I agree on both counts (i.e. it was totally unclear what > >> problem is being solved and what the root cause of the problem is, > >> and we would want a new test to protect this "fix" from getti

Re: [PATCH] range-diff: allow to diff files regardless submodule

2018-10-23 Thread Junio C Hamano
Lucas De Marchi writes: >> Yes, I agree on both counts (i.e. it was totally unclear what >> problem is being solved and what the root cause of the problem is, >> and we would want a new test to protect this "fix" from getting >> broken in the future. > > have you seen I sent a v2 with proper test

Re: [PATCH] range-diff: allow to diff files regardless submodule

2018-10-23 Thread Lucas De Marchi
On Thu, Oct 11, 2018 at 05:25:02PM +0900, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > > > On Wed, Oct 10 2018, Lucas De Marchi wrote: > > > >> Do like it's done in grep so mode doesn't end up as > >> 016, which means range-diff doesn't work if one has > >> "submodule.diff = log"

Re: [PATCH] range-diff: allow to diff files regardless submodule

2018-10-12 Thread brian m. carlson
On Fri, Oct 12, 2018 at 11:24:43AM +0200, Johannes Schindelin wrote: > > > On Thu, 11 Oct 2018, Lucas De Marchi wrote: > > > On Wed, Oct 10, 2018 at 5:02 PM brian m. carlson > > wrote: > > > > > > On Wed, Oct 10, 2018 at 08:09:16AM -0700, Lucas De Marchi wrote: > > > > Do like it's done in grep

Re: [PATCH] range-diff: allow to diff files regardless submodule

2018-10-12 Thread Johannes Schindelin
On Thu, 11 Oct 2018, Lucas De Marchi wrote: > On Wed, Oct 10, 2018 at 5:02 PM brian m. carlson > wrote: > > > > On Wed, Oct 10, 2018 at 08:09:16AM -0700, Lucas De Marchi wrote: > > > Do like it's done in grep so mode doesn't end up as > > > 016, which means range-diff doesn't work if one h

Re: [PATCH] range-diff: allow to diff files regardless submodule

2018-10-11 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > On Wed, Oct 10 2018, Lucas De Marchi wrote: > >> Do like it's done in grep so mode doesn't end up as >> 016, which means range-diff doesn't work if one has >> "submodule.diff = log" in the configuration. Without this >> while using range-diff I only get a >>

Re: [PATCH] range-diff: allow to diff files regardless submodule

2018-10-11 Thread Lucas De Marchi
On Thu, Oct 11, 2018 at 12:42 AM Ævar Arnfjörð Bjarmason wrote: > > > On Wed, Oct 10 2018, Lucas De Marchi wrote: > > > Do like it's done in grep so mode doesn't end up as > > 016, which means range-diff doesn't work if one has > > "submodule.diff = log" in the configuration. Without this > >

Re: [PATCH] range-diff: allow to diff files regardless submodule

2018-10-11 Thread Lucas De Marchi
On Wed, Oct 10, 2018 at 5:02 PM brian m. carlson wrote: > > On Wed, Oct 10, 2018 at 08:09:16AM -0700, Lucas De Marchi wrote: > > Do like it's done in grep so mode doesn't end up as > > 016, which means range-diff doesn't work if one has > > "submodule.diff = log" in the configuration. Without

Re: [PATCH] range-diff: allow to diff files regardless submodule

2018-10-11 Thread Ævar Arnfjörð Bjarmason
On Wed, Oct 10 2018, Lucas De Marchi wrote: > Do like it's done in grep so mode doesn't end up as > 016, which means range-diff doesn't work if one has > "submodule.diff = log" in the configuration. Without this > while using range-diff I only get a > > Submodule a 000...000 (new

Re: [PATCH] range-diff: allow to diff files regardless submodule

2018-10-10 Thread brian m. carlson
On Wed, Oct 10, 2018 at 08:09:16AM -0700, Lucas De Marchi wrote: > Do like it's done in grep so mode doesn't end up as > 016, which means range-diff doesn't work if one has > "submodule.diff = log" in the configuration. Without this > while using range-diff I only get a > > Submodule a 000

[PATCH] range-diff: allow to diff files regardless submodule

2018-10-10 Thread Lucas De Marchi
Do like it's done in grep so mode doesn't end up as 016, which means range-diff doesn't work if one has "submodule.diff = log" in the configuration. Without this while using range-diff I only get a Submodule a 000...000 (new submodule) instead of the diff between the revisions. S