Re: [PATCH] push: give early feedback

2013-06-24 Thread Jeff King
On Tue, Jun 25, 2013 at 12:54:17AM +0530, Ramkumar Ramachandra wrote: > Jeff King wrote: > > Leaving aside the transport API for a minute, you are always going to > > have this lack-of-information versus time problem. A refspec like ":" > > says nothing particularly useful, but it can only be expa

Re: [PATCH] push: give early feedback

2013-06-24 Thread Ramkumar Ramachandra
Jeff King wrote: > Leaving aside the transport API for a minute, you are always going to > have this lack-of-information versus time problem. A refspec like ":" > says nothing particularly useful, but it can only be expanded once > contact is made with the other side (which is what takes time). Ri

Re: [PATCH] push: give early feedback

2013-06-24 Thread Jeff King
On Tue, Jun 25, 2013 at 12:12:16AM +0530, Ramkumar Ramachandra wrote: > > 1. It does not tell very much about how the refspecs are expanded or > > what is going to happen. "git push --dry-run" gives a much more > > complete view of what will be pushed. > > Yes. > > $ git push > #

Re: [PATCH] push: give early feedback

2013-06-24 Thread Ramkumar Ramachandra
Jeff King wrote: > If your intent is to let people stop disastrous pushes before they > complete, I think there are two failings: > > 1. It does not tell very much about how the refspecs are expanded or > what is going to happen. "git push --dry-run" gives a much more > complete view of

Re: [PATCH] push: give early feedback

2013-06-24 Thread Jeff King
On Mon, Jun 24, 2013 at 11:11:02PM +0530, Ramkumar Ramachandra wrote: > There are many configuration variables that determine exactly what a > push does. Give the user early feedback so that she has a chance to > abort if she doesn't mean to push those refspecs to that destination > like: > >

Re: [PATCH] push: give early feedback

2013-06-24 Thread Junio C Hamano
Fredrik Gustafsson writes: > On Mon, Jun 24, 2013 at 11:11:02PM +0530, Ramkumar Ramachandra wrote: >> There are many configuration variables that determine exactly what a >> push does. Give the user early feedback so that she has a chance to >> abort if she doesn't mean to push those refspecs to

Re: [PATCH] push: give early feedback

2013-06-24 Thread Fredrik Gustafsson
On Mon, Jun 24, 2013 at 11:11:02PM +0530, Ramkumar Ramachandra wrote: > There are many configuration variables that determine exactly what a > push does. Give the user early feedback so that she has a chance to > abort if she doesn't mean to push those refspecs to that destination > like: > > $

[PATCH] push: give early feedback

2013-06-24 Thread Ramkumar Ramachandra
There are many configuration variables that determine exactly what a push does. Give the user early feedback so that she has a chance to abort if she doesn't mean to push those refspecs to that destination like: $ git push # pushing refspecs 'master next' to ram (^C to abort) Signed-off-by: