[PATCH] pretty: fix buffer over-read with %> and %

2017-11-28 Thread mwnx
A buffer over-read of the format string would occur with unterminated formats of the form '%>(#' and '%<(#', where '#' represents a number. This error can be witnessed by running git log under valgrind like so: valgrind git log -n1 --format='%<(42' This was due to the fact that the "not foun

Re: [PATCH] pretty: fix buffer over-read with %> and %

2017-11-27 Thread Junio C Hamano
mwnx writes: > On Mon, Nov 27, 2017 at 10:46:23AM +0900, Junio C Hamano wrote: >> By the way, Documentation/SubmittingPatches has this in "(5) Certify >> your work" section: >> >> Also notice that a real name is used in the Signed-off-by: line. Please >> don't hide your real name. > > (e

Re: [PATCH] pretty: fix buffer over-read with %> and %

2017-11-27 Thread mwnx
On Mon, Nov 27, 2017 at 10:46:23AM +0900, Junio C Hamano wrote: > By the way, Documentation/SubmittingPatches has this in "(5) Certify > your work" section: > > Also notice that a real name is used in the Signed-off-by: line. Please > don't hide your real name. I did read that document, b

Re: [PATCH] pretty: fix buffer over-read with %> and %

2017-11-26 Thread Junio C Hamano
mwnx writes: > diff --git a/pretty.c b/pretty.c > index 2f6b0ae6c..4c70bad45 100644 > --- a/pretty.c > +++ b/pretty.c > @@ -1021,7 +1021,7 @@ static size_t parse_padding_placeholder(struct strbuf > *sb, > const char *end = start + strcspn(start, ",)"); > char *next; >

[PATCH] pretty: fix buffer over-read with %> and %

2017-11-25 Thread mwnx
A buffer over-read of the format string would occur with unterminated formats of the form '%>(#' and '%<(#', where '#' represents a number. This error can be witnessed by running git log under valgrind like so: valgrind git log -n1 --format='%<(42' This was due to the fact that the "not foun