[PATCH] pack-bitmap: do not use gcc packed attribute

2014-11-26 Thread Jeff King
On Wed, Nov 26, 2014 at 03:09:45PM -0800, Junio C Hamano wrote: > * jk/pack-bitmap (2014-08-04) 1 commit > - pack-bitmap: do not use gcc packed attribute > > Hold, waiting for Karsten's replacement. I got tired of waiting, so here it is, I hope good enough for inclusion. -- >8 -- From: Karste

Re: [PATCH] pack-bitmap: do not use gcc packed attribute

2014-08-06 Thread Junio C Hamano
Karsten Blees writes: > Am 05.08.2014 20:47, schrieb Jeff King: >> On Mon, Aug 04, 2014 at 09:19:46PM +0200, Karsten Blees wrote: >> >>> Hmm, I wonder if it wouldn't be simpler to read / write the desired on-disk >>> structure directly, without copying to a uchar[6] first. >> >> Probably. My in

Re: [PATCH] pack-bitmap: do not use gcc packed attribute

2014-08-06 Thread Karsten Blees
Am 05.08.2014 20:47, schrieb Jeff King: > On Mon, Aug 04, 2014 at 09:19:46PM +0200, Karsten Blees wrote: > >> Hmm, I wonder if it wouldn't be simpler to read / write the desired on-disk >> structure directly, without copying to a uchar[6] first. > > Probably. My initial attempt was to keep togeth

Re: [PATCH] pack-bitmap: do not use gcc packed attribute

2014-08-05 Thread Jeff King
On Mon, Aug 04, 2014 at 09:19:46PM +0200, Karsten Blees wrote: > Hmm, I wonder if it wouldn't be simpler to read / write the desired on-disk > structure directly, without copying to a uchar[6] first. Probably. My initial attempt was to keep together the read/write logic about which sizes each ite

Re: [PATCH] pack-bitmap: do not use gcc packed attribute

2014-08-05 Thread Vicent Martí
On Mon, Aug 4, 2014 at 9:19 PM, Karsten Blees wrote: > This raises the question why we read via mmap at all The first version of the pack bitmap format I wrote for GitHub was 50% faster to load than this one because it was designed to be mmapable. Eventually we moved to the JGit-compatible bitmap

Re: [PATCH] pack-bitmap: do not use gcc packed attribute

2014-08-04 Thread Karsten Blees
Am 02.08.2014 01:10, schrieb Jeff King: > On Fri, Aug 01, 2014 at 06:37:39PM -0400, Jeff King wrote: > >>> Btw.: Using struct-packing on 'struct bitmap_disk_entry' means that the >>> binary format of .bitmap files is incompatible between GCC and other >>> builds, correct? >> >> The on-disk format

Re: [PATCH] pack-bitmap: do not use gcc packed attribute

2014-08-01 Thread Jeff King
On Fri, Aug 01, 2014 at 07:10:44PM -0400, Jeff King wrote: > I confirmed that this does break horribly without the packed attribute > (as you'd expect; it's asking for 48-bit alignment!). p5310 notices it, > _if_ you have jgit installed to check against. Er, that should be t5310, of course. p5310

[PATCH] pack-bitmap: do not use gcc packed attribute

2014-08-01 Thread Jeff King
On Fri, Aug 01, 2014 at 06:37:39PM -0400, Jeff King wrote: > > Btw.: Using struct-packing on 'struct bitmap_disk_entry' means that the > > binary format of .bitmap files is incompatible between GCC and other > > builds, correct? > > The on-disk format is defined by JGit; if there are differences