Re: [PATCH] object: make add_object_array_with_mode a static function

2014-10-20 Thread Jeff King
On Mon, Oct 20, 2014 at 09:21:24AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > I think we can take your patch a step further, though, like: > > > > -- >8 -- > > Subject: [PATCH] drop add_object_array_with_mode > > ... > > Thanks. I think I picked up all incrementals in this thread,

Re: [PATCH] object: make add_object_array_with_mode a static function

2014-10-20 Thread Junio C Hamano
Jeff King writes: > I think we can take your patch a step further, though, like: > > -- >8 -- > Subject: [PATCH] drop add_object_array_with_mode > ... Thanks. I think I picked up all incrementals in this thread, but please holler if I missed anything. -- To unsubscribe from this list: send the

Re: [PATCH] object: make add_object_array_with_mode a static function

2014-10-19 Thread Ramsay Jones
On 19/10/14 03:03, Jeff King wrote: > On Sun, Oct 19, 2014 at 12:19:07AM +0100, Ramsay Jones wrote: > [snip] > I actually wondered while writing this series whether anyone actually > _uses_ the mode in object_array (the new code I added sets it to the > appropriate value to be on the safe side,

Re: [PATCH] object: make add_object_array_with_mode a static function

2014-10-18 Thread Jeff King
On Sun, Oct 19, 2014 at 12:19:07AM +0100, Ramsay Jones wrote: > I noticed that your 'jk/prune-mtime' branch also removes the only > call to the add_object_array_with_mode() function outside of the > object.c file; specifically commit 75ac69fa ("traverse_commit_list: > support pending blobs/trees w

[PATCH] object: make add_object_array_with_mode a static function

2014-10-18 Thread Ramsay Jones
Signed-off-by: Ramsay Jones --- Hi Jeff, I noticed that your 'jk/prune-mtime' branch also removes the only call to the add_object_array_with_mode() function outside of the object.c file; specifically commit 75ac69fa ("traverse_commit_list: support pending blobs/trees with paths", 15-10-2014).