Re: [PATCH] merge-message: change meaning of "empty merge message"

2017-07-06 Thread Kaartic Sivaraam
On Thu, 2017-07-06 at 06:46 +0200, Kevin Daudt wrote: > > The function is called "rest_is_empty". > Thanks for correcting that! > But isn't it better that commit and merge use the same code, instead > of > duplicating it again? Otherwise one may be updated, and the other > forgotten, getting dif

Re: [PATCH] merge-message: change meaning of "empty merge message"

2017-07-05 Thread Kevin Daudt
On Thu, Jul 06, 2017 at 09:01:49AM +0530, Kaartic Sivaraam wrote: > In the context of "git merge" the meaning of an "empty message" > is one that contains no line of text. This is not in line with > "git commit" where an "empty message" is one that contains only > whitespaces and/or signed-off-by l

[PATCH] merge-message: change meaning of "empty merge message"

2017-07-05 Thread Kaartic Sivaraam
In the context of "git merge" the meaning of an "empty message" is one that contains no line of text. This is not in line with "git commit" where an "empty message" is one that contains only whitespaces and/or signed-off-by lines. This could cause surprises to users who are accustomed to the meanin