Re: [PATCH] make rebase respect core.hooksPath if set

2016-08-15 Thread ryenus
On 15 August 2016 at 20:24, Johannes Schindelin wrote: > Would it not be more appropriate to teach --git-path hooks to respect the > core.hooksPath variable? This would be in line with --git-path objects > respecting the GIT_OBJECT_DIRECTORY environment variable. Indeed, I've thought about that,

Re: [PATCH] make rebase respect core.hooksPath if set

2016-08-15 Thread Jeff King
On Mon, Aug 15, 2016 at 02:24:59PM +0200, Johannes Schindelin wrote: > > when looking for pre-rebase and post-rewrite hooks, git-rebase > > only looks for hooks dir using `git rev-parse --git-path hooks`, > > which didn't consider the path overridden by core.hooksPath. > > Would it not be more ap

Re: [PATCH] make rebase respect core.hooksPath if set

2016-08-15 Thread Johannes Schindelin
Hi ryenus, On Sun, 14 Aug 2016, ryenus wrote: > when looking for pre-rebase and post-rewrite hooks, git-rebase > only looks for hooks dir using `git rev-parse --git-path hooks`, > which didn't consider the path overridden by core.hooksPath. Would it not be more appropriate to teach --git-path ho

Re: [PATCH] make rebase respect core.hooksPath if set

2016-08-14 Thread Mike Rappazzo
On Sun, Aug 14, 2016 at 12:29 PM, ryenus wrote: > Patch attached. > > It seems gmail ruined the white spaces. > Not sure how to stop gmail from doing that. > Sorry for me, and for Gmail. Did you use git-send-email? I don't think that the gmail ui works. If you have 2-factor authentication, there

Re: [PATCH] make rebase respect core.hooksPath if set

2016-08-14 Thread ryenus
Patch attached. It seems gmail ruined the white spaces. Not sure how to stop gmail from doing that. Sorry for me, and for Gmail. 0001-make-rebase-respect-core.hooksPath-if-set.patch Description: Binary data

[PATCH] make rebase respect core.hooksPath if set

2016-08-14 Thread ryenus
when looking for pre-rebase and post-rewrite hooks, git-rebase only looks for hooks dir using `git rev-parse --git-path hooks`, which didn't consider the path overridden by core.hooksPath. Signed-off-by: ryenus --- git-rebase--interactive.sh | 14 +- git-rebase--merge.sh | 4 +