Re: [PATCH] log: add %S option (like --source) to log --format

2019-01-11 Thread Junio C Hamano
Issac Trotts writes: > Sounds good. Btw, did you queue it yet? I didn't see it at the mirror: > https://github.com/git/git/commits/master. No patch goes to 'master' directly. Once we see that a patch is in reviewable shape during the mailing list discussion, we wait for a few more days and un

Re: [PATCH] log: add %S option (like --source) to log --format

2019-01-11 Thread Junio C Hamano
Issac Trotts writes: > On Tue, Jan 8, 2019 at 2:21 PM Junio C Hamano wrote: >> >> issac.tro...@gmail.com writes: >> >> > From: Issac Trotts >> >> Heh, I'll edit this line to match S-o-b: below. > > Thanks. Otherwise I have to set up git send-email again on my work laptop. This in-body From: li

[PATCH] log: add %S option (like --source) to log --format

2019-01-10 Thread issac . trotts
From: Issac Trotts Make it possible to write for example git log --format="%H,%S" where the %S at the end is a new placeholder that prints out the ref (tag/branch) for each commit. Using %d might seem like an alternative but it only shows the ref for the last commit in the branch. Sig

Re: [PATCH] log: add %S option (like --source) to log --format

2019-01-10 Thread Issac Trotts
On Tue, Jan 8, 2019 at 2:21 PM Junio C Hamano wrote: > > issac.tro...@gmail.com writes: > > > From: Issac Trotts > > Heh, I'll edit this line to match S-o-b: below. Thanks. Otherwise I have to set up git send-email again on my work laptop. > > Make it possible to write for example > > > >

Re: [PATCH] log: add %S option (like --source) to log --format

2019-01-08 Thread Junio C Hamano
issac.tro...@gmail.com writes: > From: Issac Trotts Heh, I'll edit this line to match S-o-b: below. > > Make it possible to write for example > > git log --format="%H,%S" > > where the %S at the end is a new placeholder that prints out the ref > (tag/branch) for each commit. > > Using %

[PATCH] log: add %S option (like --source) to log --format

2019-01-08 Thread issac . trotts
From: Issac Trotts Make it possible to write for example git log --format="%H,%S" where the %S at the end is a new placeholder that prints out the ref (tag/branch) for each commit. Using %d might seem like an alternative but it only shows the ref for the last commit in the branch. Sig

Re: [PATCH] log: add %S option (like --source) to log --format

2019-01-08 Thread Issac Trotts
On Thu, Jan 3, 2019 at 6:33 AM Junio C Hamano wrote: > > issac.tro...@gmail.com writes: > > > From: Issac Trotts > > I think you want to have > > From: Issac Trotts > > instead, so that the authorship actually matches your sign-off. Makes sense. I'll do that. > > > - if (source) {

Re: [PATCH] log: add %S option (like --source) to log --format

2019-01-02 Thread Junio C Hamano
issac.tro...@gmail.com writes: > From: Issac Trotts I think you want to have From: Issac Trotts instead, so that the authorship actually matches your sign-off. > - if (source) { > + if (source || (rev->pretty_given && (rev->commit_format == > CMIT_FMT_USERFORMAT) && w.sourc

[PATCH] log: add %S option (like --source) to log --format

2018-12-31 Thread issac . trotts
From: Issac Trotts Make it possible to write for example git log --format="%H,%S" where the %S at the end is a new placeholder that prints out the ref (tag/branch) for each commit. Using %d might seem like an alternative but it only shows the ref for the last commit in the branch. Sig

[PATCH] log: add %S option (like --source) to log --format

2018-12-30 Thread issac . trotts
From: Issac Trotts Make it possible to write for example git log --format="%H,%S" where the %S at the end is a new placeholder that prints out the ref (tag/branch) for each commit. Using %d might seem like an alternative but it only shows the ref for the last commit in the branch. Sig

Re: [PATCH] log: add %S option (like --source) to log --format

2018-12-30 Thread Issac Trotts
Hi Derrick, thanks for your feedback. I'll send out a new patch with the changes. On Fri, Dec 28, 2018 at 12:20 AM Derrick Stolee wrote: > > On 12/19/2018 3:33 AM, issac.tro...@gmail.com wrote: > > From: Issac Trotts > > > > Make it possible to write for example > > > > git log --forma

Re: [PATCH] log: add %S option (like --source) to log --format

2018-12-28 Thread Junio C Hamano
Derrick Stolee writes: >> +++ b/Documentation/pretty-formats.txt >> @@ -134,6 +134,8 @@ The placeholders are: >> - '%cI': committer date, strict ISO 8601 format >> - '%d': ref names, like the --decorate option of linkgit:git-log[1] >> - '%D': ref names without the " (", ")" wrapping. >> +-

Re: [PATCH] log: add %S option (like --source) to log --format

2018-12-27 Thread Derrick Stolee
On 12/19/2018 3:33 AM, issac.tro...@gmail.com wrote: From: Issac Trotts Make it possible to write for example git log --format="%H,%S" where the %S at the end is a new placeholder that prints out the ref (tag/branch) for each commit. Using %d might seem like an alternative but it on

Re: [PATCH] log: add %S option (like --source) to log --format

2018-12-24 Thread Issac Trotts
Got it, sounds good. On Sat, Dec 22, 2018 at 2:22 PM Jeff King wrote: > > On Thu, Dec 20, 2018 at 09:24:10PM -0800, Issac Trotts wrote: > > > Hi all, friendly ping. Is there still interest in merging this patch? > > Yes, but I think people are largely absent for holidays at this point. > If there

Re: [PATCH] log: add %S option (like --source) to log --format

2018-12-22 Thread Jeff King
On Thu, Dec 20, 2018 at 09:24:10PM -0800, Issac Trotts wrote: > Hi all, friendly ping. Is there still interest in merging this patch? Yes, but I think people are largely absent for holidays at this point. If there hasn't been any movement on it, I'll try to review after Jan 5th (it also wouldn't

Re: [PATCH] log: add %S option (like --source) to log --format

2018-12-20 Thread Issac Trotts
Hi all, friendly ping. Is there still interest in merging this patch? Thanks, Issac On Wed, Dec 19, 2018 at 12:33 AM wrote: > > From: Issac Trotts > > Make it possible to write for example > > git log --format="%H,%S" > > where the %S at the end is a new placeholder that prints out the

Re: [PATCH] log: add %S option (like --source) to log --format

2018-12-19 Thread Issac Trotts
Looks like that was a flake. Everything passes now. https://travis-ci.org/ijt/git/builds/469843833 On Wed, Dec 19, 2018 at 12:07 AM Issac Trotts wrote: > > Travis showed one failure. I'm not sure if it's a flake. > https://travis-ci.org/ijt/git/builds/469843833. Rerunning it. > > On Tue, Dec 18,

[PATCH] log: add %S option (like --source) to log --format

2018-12-19 Thread issac . trotts
From: Issac Trotts Make it possible to write for example git log --format="%H,%S" where the %S at the end is a new placeholder that prints out the ref (tag/branch) for each commit. Using %d might seem like an alternative but it only shows the ref for the last commit in the branch. Sig

Re: [PATCH] log: add %S option (like --source) to log --format

2018-12-19 Thread Issac Trotts
Travis showed one failure. I'm not sure if it's a flake. https://travis-ci.org/ijt/git/builds/469843833. Rerunning it. On Tue, Dec 18, 2018 at 7:47 PM Issac Trotts wrote: > > On Tue, Dec 18, 2018 at 9:14 AM Issac Trotts wrote: > > > > Hi Peff, thanks for the feedback. I tried a variant of the co

Re: [PATCH] log: add %S option (like --source) to log --format

2018-12-18 Thread Issac Trotts
On Tue, Dec 18, 2018 at 9:14 AM Issac Trotts wrote: > > Hi Peff, thanks for the feedback. I tried a variant of the command you > showed and it yielded a seg fault: > ``` > [ issactrotts ~/git ] ./git diff-tree -s --pretty=tformat:'%S %H %s' HEAD > Segmentation fault: 11 > ``` > I'll see if I can t

Re: [PATCH] log: add %S option (like --source) to log --format

2018-12-18 Thread Issac Trotts
Hi Peff, thanks for the feedback. I tried a variant of the command you showed and it yielded a seg fault: ``` [ issactrotts ~/git ] ./git diff-tree -s --pretty=tformat:'%S %H %s' HEAD Segmentation fault: 11 ``` I'll see if I can track it down this evening. Issac On Mon, Dec 17, 2018 at 7:59 AM Je

Re: [PATCH] log: add %S option (like --source) to log --format

2018-12-17 Thread Issac Trotts
Hi Junio, thanks for your feedback. I'll submit a new patch as soon as I've addressed all the feedback. On Mon, Dec 17, 2018 at 1:31 AM Junio C Hamano wrote: > > Issac Trotts writes: > > > Make it possible to write for example > > > > git log --format="%H,%S" > > > > where the %S at the

Re: [PATCH] log: add %S option (like --source) to log --format

2018-12-17 Thread Jeff King
On Sun, Dec 16, 2018 at 10:25:14PM -0800, Issac Trotts wrote: > Make it possible to write for example > > git log --format="%H,%S" > > where the %S at the end is a new placeholder that prints out the ref > (tag/branch) for each commit. Seems like a reasonable thing to want. One curious

Re: [PATCH] log: add %S option (like --source) to log --format

2018-12-17 Thread Junio C Hamano
Issac Trotts writes: > Make it possible to write for example > > git log --format="%H,%S" > > where the %S at the end is a new placeholder that prints out the ref > (tag/branch) for each commit. > > Using %d might seem like an alternative but it only shows the ref for > the last commit in

[PATCH] log: add %S option (like --source) to log --format

2018-12-16 Thread Issac Trotts
Make it possible to write for example git log --format="%H,%S" where the %S at the end is a new placeholder that prints out the ref (tag/branch) for each commit. Using %d might seem like an alternative but it only shows the ref for the last commit in the branch. This change is based on