Re: [PATCH] lib-submodule-update.sh: drop unneeded shell

2017-01-13 Thread Junio C Hamano
Stefan Beller writes: > On Fri, Jan 13, 2017 at 11:55 AM, Junio C Hamano wrote: >> Junio C Hamano writes: >> >>> Stefan Beller writes: >>> In modern Git we prefer "git -C )" as it doesn't need an extra shell. >>> >>> There is a matching '>' missing. The description is correct (I am

Re: [PATCH] lib-submodule-update.sh: drop unneeded shell

2017-01-13 Thread Stefan Beller
On Fri, Jan 13, 2017 at 11:55 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Stefan Beller writes: >> >>> In modern Git we prefer "git -C )" >>> as it doesn't need an extra shell. >> >> There is a matching '>' missing. The description is correct (I am >> not sure if there actually is "

Re: [PATCH] lib-submodule-update.sh: drop unneeded shell

2017-01-13 Thread Junio C Hamano
Junio C Hamano writes: > Stefan Beller writes: > >> In modern Git we prefer "git -C )" >> as it doesn't need an extra shell. > > There is a matching '>' missing. The description is correct (I am > not sure if there actually is "preference", though), but I found the > title a bit misleading

Re: [PATCH] lib-submodule-update.sh: drop unneeded shell

2017-01-13 Thread Junio C Hamano
Stefan Beller writes: > In modern Git we prefer "git -C )" > as it doesn't need an extra shell. There is a matching '>' missing. The description is correct (I am not sure if there actually is "preference", though), but I found the title a bit misleading. With 'drop unneeded subshell', I would

[PATCH] lib-submodule-update.sh: drop unneeded shell

2017-01-11 Thread Stefan Beller
In modern Git we prefer "git -C )" as it doesn't need an extra shell. Signed-off-by: Stefan Beller --- And because it is in a setup function, we actually save the invocation of 22 shells for a single run of the whole test suite. Noticed while adding a lot more in near vincinity, though not as n