Re: [PATCH] lib-httpd/apache.conf: check version only after mod_version loads

2013-06-21 Thread Junio C Hamano
Jeff King writes: > Cool. I think the patch should look like the one below, then. > > Just to double-check that I have explained the issue correctly, can you > share the output of "apache2 -l"? Mine has: > > $ apache2 -l > Compiled in modules: > core.c > mod_log_config.c > mod_log

Re: [PATCH] lib-httpd/apache.conf: check version only after mod_version loads

2013-06-21 Thread Jeff King
On Fri, Jun 21, 2013 at 02:15:39PM -0400, Brian Gernhardt wrote: > > Cool. I think the patch should look like the one below, then. > > Basically identical to what I've done, you're just faster to the actual > patch. :-D I started writing the rationale immediately after making the suggestion, b

Re: [PATCH] lib-httpd/apache.conf: check version only after mod_version loads

2013-06-21 Thread Brian Gernhardt
On Jun 21, 2013, at 2:12 PM, Jeff King wrote: > On Fri, Jun 21, 2013 at 02:08:49PM -0400, Brian Gernhardt wrote: > >> On Jun 21, 2013, at 2:03 PM, Jeff King wrote: >> >>> IfVersion comes from mod_version. I assume that if it were not >>> loaded, apache would complain about the directive entir

[PATCH] lib-httpd/apache.conf: check version only after mod_version loads

2013-06-21 Thread Jeff King
On Fri, Jun 21, 2013 at 02:08:49PM -0400, Brian Gernhardt wrote: > On Jun 21, 2013, at 2:03 PM, Jeff King wrote: > > > IfVersion comes from mod_version. I assume that if it were not > > loaded, apache would complain about the directive entirely. But it's > > true that we don't load it until late