Re: [PATCH] http.c: shell command evaluation for extraheader

2018-04-28 Thread Johannes Schindelin
Hi Colin, On Tue, 6 Mar 2018, Colin Arnott wrote: > On March 5, 2018 1:47 PM, Johannes Schindelin > wrote: > > > As the credential-helper is already intended for sensitive data, and > > as it already allows to interact with a helper, I would strongly > > assume that it would make more sense to

Re: [PATCH] http.c: shell command evaluation for extraheader

2018-03-05 Thread Colin Arnott
Johannes, On March 5, 2018 1:47 PM, Johannes Schindelin wrote: > As the credential-helper is already intended for sensitive data, and as it > already allows to interact with a helper, I would strongly assume that it > would make more sense to try to extend that feature (instead of the simple >

Re: [PATCH] http.c: shell command evaluation for extraheader

2018-03-05 Thread Johannes Schindelin
Hi Colin, On Sun, 4 Mar 2018, Colin Arnott wrote: > The http.extraHeader config parameter currently only supports storing > constant values. There are two main use cases where this fails: > > 0. Sensitive payloads: frequently this config parameter is used to pass > authentication credenti

[PATCH] http.c: shell command evaluation for extraheader

2018-03-04 Thread Colin Arnott
The http.extraHeader config parameter currently only supports storing constant values. There are two main use cases where this fails: 0. Sensitive payloads: frequently this config parameter is used to pass authentication credentials in place of or in addition to the Authorization heade