Re: [PATCH] http: use curl's tcp keepalive if available

2013-10-14 Thread Eric Wong
Jeff King wrote: > I am more concerned with Windows, which may not compile your original > patch at all. The code I introduced in e47a8583a20256851e7fc882233e3bd5bf33dc6e ("enable SO_KEEPALIVE for connected TCP sockets" Dec 2011) didn't trigger the addition of any new #ifdef guards. I think we'r

Re: [PATCH] http: use curl's tcp keepalive if available

2013-10-14 Thread Jeff King
On Tue, Oct 15, 2013 at 04:58:14AM +, Eric Wong wrote: > > Subject: http: use curl's tcp keepalive if available > [...] > Tested-by: Eric Wong > on curl 7.21.0 and 7.26.0, confirmed via strace: > > setsockopt(fd, SOL_SOCKET, SO_KEEPALIVE, [1], 4) = 0 > > I can also confirm 7.26.0 adds

Re: [PATCH] http: use curl's tcp keepalive if available

2013-10-14 Thread Eric Wong
Jeff King wrote: > On Mon, Oct 14, 2013 at 11:38:39PM +, Eric Wong wrote: > > > I wanted it to work as older curl first (since I noticed this > > on an old server). But your patch on top of mine looks reasonable, > > thanks. > > Makes sense. Here it is with a real commit message (on top of

[PATCH] http: use curl's tcp keepalive if available

2013-10-14 Thread Jeff King
On Mon, Oct 14, 2013 at 11:38:39PM +, Eric Wong wrote: > I wanted it to work as older curl first (since I noticed this > on an old server). But your patch on top of mine looks reasonable, > thanks. Makes sense. Here it is with a real commit message (on top of the ew/keepalive topic). -- >8