On Wed, Mar 16, 2016 at 11:36:49PM +0600, Alexander Kuleshov wrote:
> > I also wonder if this should be sharing the strip_extension() helper
> > added in your 63ca1c0.
>
> Yes, I want to move strip_extension() (from 63ca1c0) to the git-compat-util.h
> and adapt/reuse it in the help.c. What do you
On Wed, Mar 16, 2016 at 08:27:29PM +0600, Alexander Kuleshov wrote:
> We stripping extension in the list_commands_in_dir() to get
> commands without '.exe' suffix. Let's do it only if STRIP_EXTENSION
> is defined to not spend time for unnecessary strip_suffix() call in
> this case.
>
> Signed-off
We stripping extension in the list_commands_in_dir() to get
commands without '.exe' suffix. Let's do it only if STRIP_EXTENSION
is defined to not spend time for unnecessary strip_suffix() call in
this case.
Signed-off-by: Alexander Kuleshov
---
help.c | 5 +++--
1 file changed, 3 insertions(+),
On Wed, Mar 16, 2016 at 9:27 PM, Alexander Kuleshov
wrote:
> We stripping extension in the list_commands_in_dir() to get
> commands without '.exe' suffix. Let's do it only if STRIP_EXTENSION
> is defined to not spend time for unnecessary strip_suffix() call in
> this case.
Unless the time saving
Hello Jeff,
On Wed, Mar 16, 2016 at 11:31 PM, Jeff King wrote:
> This is billed as an optimization in the commit message, but these two
> pieces of code are not the same. The original always strips ".exe",
> whether or not STRIP_EXTENSION is defined, and whether or not it is
> ".exe".
>
> In prac
On Wed, Mar 16, 2016 at 8:47 PM, Duy Nguyen wrote:
> On Wed, Mar 16, 2016 at 9:27 PM, Alexander Kuleshov
> wrote:
>> We stripping extension in the list_commands_in_dir() to get
>> commands without '.exe' suffix. Let's do it only if STRIP_EXTENSION
>> is defined to not spend time for unnecessary s
6 matches
Mail list logo
