Re: [PATCH] help: make option --help open man pages only for Git commands

2016-08-13 Thread Junio C Hamano
"Philip Oakley" writes: > But does it cope with the Guides? Should it cope if spelt that way? > > git help revisions > git revisions --help Hmph. Ralf's patch is not just "I wonder if we could do a bit better" but is also a regression. I do not particularly care if the latter stops working, bu

Re: [PATCH] help: make option --help open man pages only for Git commands

2016-08-12 Thread Philip Oakley
From: "Junio C Hamano" To: "Ralf Thielow" Cc: ; ; Sent: Friday, August 12, 2016 11:53 PM Subject: Re: [PATCH] help: make option --help open man pages only for Git commands Junio C Hamano writes: I love it when I say "This shouldn't be too hard; somebody

Re: [PATCH] help: make option --help open man pages only for Git commands

2016-08-12 Thread Junio C Hamano
Junio C Hamano writes: > I love it when I say "This shouldn't be too hard; somebody may want > to do a patch", with just a vague implemention idea in my head, and > a patch magically appears with even a better design than I had in > mind when I said it [*1*] ;-) Having said that, I wonder if we

Re: [PATCH] help: make option --help open man pages only for Git commands

2016-08-12 Thread Junio C Hamano
Ralf Thielow writes: > If option --help is passed to a Git command, we try to open > the man page of that command. However, we do it even for commands > we don't know. Make sure the command is known to Git before try > to open the man page. If we don't know the command, give the > usual advice.

[PATCH] help: make option --help open man pages only for Git commands

2016-08-12 Thread Ralf Thielow
If option --help is passed to a Git command, we try to open the man page of that command. However, we do it even for commands we don't know. Make sure the command is known to Git before try to open the man page. If we don't know the command, give the usual advice. Signed-off-by: Ralf Thielow --