Re: [PATCH] help: ensure that common-cmds.h is only included by help.c

2014-09-14 Thread David Aguilar
On Sun, Sep 14, 2014 at 12:55:41AM -0700, Perry Hutchison wrote: > Junio C Hamano wrote: > > On Sat, Sep 13, 2014 at 7:00 PM, Perry Hutchison > > wrote: > > > David Aguilar wrote: > > >> Add a #ifndef guard to ensure that common-cmds.h can only > > >> be included by help.c. > > > > > > ... If t

Re: [PATCH] help: ensure that common-cmds.h is only included by help.c

2014-09-14 Thread Perry Hutchison
Junio C Hamano wrote: > On Sat, Sep 13, 2014 at 7:00 PM, Perry Hutchison > wrote: > > David Aguilar wrote: > >> Add a #ifndef guard to ensure that common-cmds.h can only > >> be included by help.c. > > > > ... If these definitions are intended to be private to help.c, > > why not put them there

Re: [PATCH] help: ensure that common-cmds.h is only included by help.c

2014-09-14 Thread David Aguilar
On Sat, Sep 13, 2014 at 10:23:03PM -0700, Junio C Hamano wrote: > On Sat, Sep 13, 2014 at 7:00 PM, Perry Hutchison > wrote: > > David Aguilar wrote: > >> Add a #ifndef guard to ensure that common-cmds.h can only > >> be included by help.c. > > > > This strikes me as a very peculiar, and sub-opti

Re: [PATCH] help: ensure that common-cmds.h is only included by help.c

2014-09-13 Thread Junio C Hamano
On Sat, Sep 13, 2014 at 7:00 PM, Perry Hutchison wrote: > David Aguilar wrote: >> Add a #ifndef guard to ensure that common-cmds.h can only >> be included by help.c. > > This strikes me as a very peculiar, and sub-optimal, way of > achieving the purpose. If these definitions are intended to > be

Re: [PATCH] help: ensure that common-cmds.h is only included by help.c

2014-09-13 Thread Perry Hutchison
David Aguilar wrote: > Add a #ifndef guard to ensure that common-cmds.h can only > be included by help.c. This strikes me as a very peculiar, and sub-optimal, way of achieving the purpose. If these definitions are intended to be private to help.c, why not put them there and eliminate common-cmds

[PATCH] help: ensure that common-cmds.h is only included by help.c

2014-09-13 Thread David Aguilar
Add a #ifndef guard to ensure that common-cmds.h can only be included by help.c. Suggested-by: Junio C Hamano Signed-off-by: David Aguilar --- generate-cmdlist.sh | 4 help.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/generate-cmdlist.sh b/generate-