Re: [PATCH] hashmap: add API to disable item counting when threaded

2017-09-06 Thread Jeff Hostetler
On 9/5/2017 9:24 PM, Junio C Hamano wrote: Jeff Hostetler writes: From: Jeff Hostetler I feel somewhat stupid to say this, especially after seeing many people applaud this patch, but I do not seem to be able to even build Git with this patch. I am getting: common-main.o: In functi

Re: [PATCH] hashmap: add API to disable item counting when threaded

2017-09-05 Thread Junio C Hamano
Jeff King writes: > On Sat, Sep 02, 2017 at 01:31:19AM +0200, Johannes Schindelin wrote: > >> BTW this made me think that we may have a problem in our code since >> switching from my original hashmap implementation to the bucket one added >> in 6a364ced497 (add a hashtable implementation that sup

Re: [PATCH] hashmap: add API to disable item counting when threaded

2017-09-05 Thread Junio C Hamano
Jeff Hostetler writes: > From: Jeff Hostetler > > This is to address concerns raised by ThreadSanitizer on the > mailing list about threaded unprotected R/W access to map.size with my > previous > "disallow rehash" change (0607e10009ee4e37cb49b4cec8d28a9dda1656a4). See: > https://public-inbox.

Re: [PATCH] hashmap: add API to disable item counting when threaded

2017-09-05 Thread Martin Ågren
On 5 September 2017 at 18:39, Jeff Hostetler wrote: > > > On 9/1/2017 7:50 PM, Jonathan Nieder wrote: >> >> Hi, >> >> Johannes Schindelin wrote: >>> >>> On Wed, 30 Aug 2017, Jeff Hostetler wrote: >> >> This is to address concerns raised by ThreadSanitizer on the mailing list about thread

Re: [PATCH] hashmap: add API to disable item counting when threaded

2017-09-05 Thread Jeff Hostetler
On 9/2/2017 4:05 AM, Jeff King wrote: On Wed, Aug 30, 2017 at 06:59:22PM +, Jeff Hostetler wrote: From: Jeff Hostetler This is to address concerns raised by ThreadSanitizer on the mailing list about threaded unprotected R/W access to map.size with my previous "disallow rehash" change (0

Re: [PATCH] hashmap: add API to disable item counting when threaded

2017-09-05 Thread Jeff Hostetler
On 9/2/2017 4:17 AM, Jeff King wrote: On Sat, Sep 02, 2017 at 01:31:19AM +0200, Johannes Schindelin wrote: Before anybody can ask for this message to be wrapped in _(...) to be translateable, let me suggest instead to add the prefix "BUG: ". Agreed on both (and Jonathan's suggestion to just

Re: [PATCH] hashmap: add API to disable item counting when threaded

2017-09-05 Thread Jeff Hostetler
On 9/1/2017 7:50 PM, Jonathan Nieder wrote: Hi, Johannes Schindelin wrote: On Wed, 30 Aug 2017, Jeff Hostetler wrote: This is to address concerns raised by ThreadSanitizer on the mailing list about threaded unprotected R/W access to map.size with my previous "disallow rehash" change (0607e

Re: [PATCH] hashmap: add API to disable item counting when threaded

2017-09-05 Thread Jeff Hostetler
On 9/1/2017 7:31 PM, Johannes Schindelin wrote: Hi Jeff, On Wed, 30 Aug 2017, Jeff Hostetler wrote: From: Jeff Hostetler This is to address concerns raised by ThreadSanitizer on the mailing list about threaded unprotected R/W access to map.size with my previous "disallow rehash" change (06

Re: [PATCH] hashmap: add API to disable item counting when threaded

2017-09-04 Thread Johannes Schindelin
Hi Peff, On Sat, 2 Sep 2017, Jeff King wrote: > On Sat, Sep 02, 2017 at 01:31:19AM +0200, Johannes Schindelin wrote: > > > > https://public-inbox.org/git/adb37b70139fd1e2bac18bfd22c8b96683ae18eb.1502780344.git.martin.ag...@gmail.com/ > > [...] > > > +static inline void hashmap_enable_item_counti

Re: [PATCH] hashmap: add API to disable item counting when threaded

2017-09-02 Thread Simon Ruderich
On Wed, Aug 30, 2017 at 06:59:22PM +, Jeff Hostetler wrote: > [snip] > +/* > + * Re-enable item couting when adding/removing items. > + * If counting is currently disabled, it will force count them. The code always recounts them. Either the comment or the code should be adjusted. > + * This m

Re: [PATCH] hashmap: add API to disable item counting when threaded

2017-09-02 Thread Jeff King
On Sat, Sep 02, 2017 at 01:31:19AM +0200, Johannes Schindelin wrote: > > https://public-inbox.org/git/adb37b70139fd1e2bac18bfd22c8b96683ae18eb.1502780344.git.martin.ag...@gmail.com/ > [...] > > Add API to hashmap to disable item counting and to disable automatic > > rehashing. Also include APIs t

Re: [PATCH] hashmap: add API to disable item counting when threaded

2017-09-02 Thread Jeff King
On Wed, Aug 30, 2017 at 06:59:22PM +, Jeff Hostetler wrote: > From: Jeff Hostetler > > This is to address concerns raised by ThreadSanitizer on the > mailing list about threaded unprotected R/W access to map.size with my > previous > "disallow rehash" change (0607e10009ee4e37cb49b4cec8d28a9

Re: [PATCH] hashmap: add API to disable item counting when threaded

2017-09-01 Thread Jonathan Nieder
Hi, Johannes Schindelin wrote: > On Wed, 30 Aug 2017, Jeff Hostetler wrote: >> This is to address concerns raised by ThreadSanitizer on the mailing >> list about threaded unprotected R/W access to map.size with my previous >> "disallow rehash" change (0607e10009ee4e37cb49b4cec8d28a9dda1656a4). N

Re: [PATCH] hashmap: add API to disable item counting when threaded

2017-09-01 Thread Johannes Schindelin
Hi Jeff, On Wed, 30 Aug 2017, Jeff Hostetler wrote: > From: Jeff Hostetler > > This is to address concerns raised by ThreadSanitizer on the mailing > list about threaded unprotected R/W access to map.size with my previous > "disallow rehash" change (0607e10009ee4e37cb49b4cec8d28a9dda1656a4). >

[PATCH] hashmap: add API to disable item counting when threaded

2017-08-30 Thread Jeff Hostetler
From: Jeff Hostetler This is to address concerns raised by ThreadSanitizer on the mailing list about threaded unprotected R/W access to map.size with my previous "disallow rehash" change (0607e10009ee4e37cb49b4cec8d28a9dda1656a4). See: https://public-inbox.org/git/adb37b70139fd1e2bac18bfd22c8b96