Re: [PATCH] grep: under --debug, show whether PCRE JIT is enabled

Carlo Arenas writes: >> > ... but >> > ab/pcre-jit-fixes and UTF-8 validation are likely to make that more >> > difficult (even if it is a mostly self inflicted wound AFAIK) >> ... > for example 685668faaa (grep: stop using a custom JIT stack with PCRE > v1, 2019-07-26) adds 2 regressions as dis

Re: [PATCH] grep: under --debug, show whether PCRE JIT is enabled

On Mon, Aug 26, 2019 at 9:02 AM Junio C Hamano wrote: > > Carlo Arenas writes: > > > ... but > > ab/pcre-jit-fixes and UTF-8 validation are likely to make that more > > difficult (even if it is a mostly self inflicted wound AFAIK) > > Hmm, in what way? Do you mean that we'd be invested even more

Re: [PATCH] grep: under --debug, show whether PCRE JIT is enabled

Carlo Arenas writes: > ... but > ab/pcre-jit-fixes and UTF-8 validation are likely to make that more > difficult (even if it is a mostly self inflicted wound AFAIK) Hmm, in what way? Do you mean that we'd be invested even more in pcre1 in an effort to keep supporting, that the sunk cost would d

Re: [PATCH] grep: under --debug, show whether PCRE JIT is enabled

On Mon, Aug 26, 2019 at 7:29 AM Johannes Schindelin wrote: > > On Sat, 24 Aug 2019, Carlo Arenas wrote: > > > On Mon, Aug 19, 2019 at 3:23 PM Junio C Hamano wrote: > > > > > > There may be others I am missing. > > > > should we still support PCRE1? > > While Git for Windows has no problem to just

Re: [PATCH] grep: under --debug, show whether PCRE JIT is enabled

Hi Carlo, On Sat, 24 Aug 2019, Carlo Arenas wrote: > On Mon, Aug 19, 2019 at 3:23 PM Junio C Hamano wrote: > > > > There may be others I am missing. > > should we still support PCRE1? While Git for Windows has no problem to just drop PCRE1 support, I would like to take a longer road in Git. Lik

Re: [PATCH] grep: under --debug, show whether PCRE JIT is enabled

On Mon, Aug 19, 2019 at 3:23 PM Junio C Hamano wrote: > > There may be others I am missing. should we still support PCRE1? I think in this case the problem is compounded by the fact that unless we do something like [1], the real fix for those UTF-8 validation issues will require a yet unreleased

Re: [PATCH] grep: under --debug, show whether PCRE JIT is enabled

Beat Bolli writes: > This information is useful and not visible anywhere else, so show it. > > Signed-off-by: Beat Bolli > Suggested-by: Johannes Schindelin > > --- > This applies on top of 'ab/pcre-jit-fixes', currently in pu. Thanks. We saw a few people exchanging patches on the list and

[PATCH] grep: under --debug, show whether PCRE JIT is enabled

This information is useful and not visible anywhere else, so show it. Signed-off-by: Beat Bolli Suggested-by: Johannes Schindelin --- This applies on top of 'ab/pcre-jit-fixes', currently in pu. grep.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/grep.c b/grep.c index 9bc589720b