Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names

2014-03-17 Thread Kicer Jiao
Dear all, I have a git-project which source code use gbk encoding. When use gitweb blame view, it will report an error then stop parse: >Malformed UTF-8 character (fatal) at /usr/share/gitweb/gitweb.cgi line > 1595, <$fd> line 45. After apply this patch, blame view of gbk source file will ba

Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names

2014-03-17 Thread Kicer Jiao
Dear all, I have a git-project which source code use gbk encoding. When use gitweb blame view, it will report an error then stop parse: >Malformed UTF-8 character (fatal) at /usr/share/gitweb/gitweb.cgi line > 1595, <$fd> line 45. After apply this patch, blame view of gbk source file will ba

Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names

2013-08-31 Thread Jakub Narębski
On Fri, Aug 30, 2013 at 11:39 PM, Kyle J. McKay wrote: > On Aug 30, 2013, at 11:13, Junio C Hamano wrote: >> Junio C Hamano writes: >>> Ævar Arnfjörð Bjarmason writes: + binmode $fh, ':utf8'; > What happens if the author name is written in ISO-8859-1 instead of UTF-8 in > the actua

Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names

2013-08-31 Thread Ævar Arnfjörð Bjarmason
I did. I just clumsily sent out the wrong patch. I.e. tested it manually on another system, and then fat-fingered $fh instead of $fd. Should I send another patch or do you want to just fix this one up? On Fri, Aug 30, 2013 at 8:13 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Ævar Arn

Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names

2013-08-30 Thread Kyle J. McKay
On Aug 30, 2013, at 11:13, Junio C Hamano wrote: Junio C Hamano writes: Ævar Arnfjörð Bjarmason writes: Acked-by: Jakub Narębski Tested-by: Ævar Arnfjörð Bjarmason Tested-by: Simon Ruderich --- +++ b/gitweb/gitweb.perl @@ -6631,6 +6631,7 @@ sub git_blame_common { ... + binmode $fh

Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names

2013-08-30 Thread Simon Ruderich
On Fri, Aug 30, 2013 at 11:13:19AM -0700, Junio C Hamano wrote: > I think in this function the filehandle is called $fd, not $fh. Has > any of you really tested this??? I did, but I applied the change by hand without applying the patch directly and didn't notice the difference. Sorry for that. R

Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names

2013-08-30 Thread Junio C Hamano
Junio C Hamano writes: > Ævar Arnfjörð Bjarmason writes: > >> Acked-by: Jakub Narębski >> Tested-by: Ævar Arnfjörð Bjarmason >> Tested-by: Simon Ruderich >> --- >> +++ b/gitweb/gitweb.perl >> @@ -6631,6 +6631,7 @@ sub git_blame_common { >> ... >> +binmode $fh, ':utf8'; > > [Fri Aug 30 1

Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names

2013-08-30 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Acked-by: Jakub Narębski > Tested-by: Ævar Arnfjörð Bjarmason > Tested-by: Simon Ruderich > --- > gitweb/gitweb.perl | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl > index f429f75..ad48a5a 100755 > --- a/gitw

Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names

2013-08-30 Thread Jakub Narębski
On Fri, Aug 30, 2013 at 8:05 PM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: >> Acked-by: Jakub Narębski >> Tested-by: Ævar Arnfjörð Bjarmason >> Tested-by: Simon Ruderich >> --- >> gitweb/gitweb.perl | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/gitweb/gitweb.perl

[PATCH] gitweb: Fix the author initials in blame for non-ASCII names

2013-08-30 Thread Ævar Arnfjörð Bjarmason
Change the @author_initials feature Jakub added in v1.6.4-rc2-14-ga36817b to match non-ASCII author initials as intended. The regexp Jakub added was intended to match non-ASCII (/\b([[:upper:]])\B/g). But in Perl this doesn't actually match non-ASCII upper-case characters unless the string being m