Re: [PATCH] git svn: reset invalidates the memoized mergeinfo caches

2012-08-08 Thread Eric Wong
Peter Baumann wrote: > On Tue, Aug 07, 2012 at 08:45:10PM +, Eric Wong wrote: > > Peter Baumann wrote: > > > + for my $suffix (qw(yaml db)) { > > > + unlink("$cache_file.$suffix"); > > > > Need to check for unlink() errors (and ignore ENOENT). > > I'm

Re: [PATCH] git svn: reset invalidates the memoized mergeinfo caches

2012-08-07 Thread Peter Baumann
On Tue, Aug 07, 2012 at 08:45:10PM +, Eric Wong wrote: > Peter Baumann wrote: > > Therefore the easiest solution to clear the cache is to delete the files > > on disk in 'git svn reset'. Normally, deleting the files behind the back > > of the memoization module would be problematic, because th

Re: [PATCH] git svn: reset invalidates the memoized mergeinfo caches

2012-08-07 Thread Eric Wong
Peter Baumann wrote: > Therefore the easiest solution to clear the cache is to delete the files > on disk in 'git svn reset'. Normally, deleting the files behind the back > of the memoization module would be problematic, because the in-memory > representation would still exist and contain wrong da

[PATCH] git svn: reset invalidates the memoized mergeinfo caches

2012-08-07 Thread Peter Baumann
Since v1.7.0-rc2~11 (git-svn: persistent memoization, 2010-01-30), git-svn has maintained some private per-repository caches in .git/svn/.caches to avoid refetching and recalculating some mergeinfo-related information with every 'git svn fetch'. This memoization can cause problems, e.g consider th