Re: [PATCH] git p4: chdir resolves symlinks only for relative paths

2013-03-07 Thread John Keeping
On Thu, Mar 07, 2013 at 09:36:06AM +0100, Miklós Fazekas wrote: > Sorry for the late turnaround here is an improved version. Now chdir > has an optional argument client_path, if it's true then we don't do > os.getcwd. I think that my first patch is also valid too - when the > path is absolute no ne

Re: [PATCH] git p4: chdir resolves symlinks only for relative paths

2013-03-07 Thread Miklós Fazekas
Sorry for the late turnaround here is an improved version. Now chdir has an optional argument client_path, if it's true then we don't do os.getcwd. I think that my first patch is also valid too - when the path is absolute no need for getcwd no matter what is the context, when it's relative we have

Re: [PATCH] git p4: chdir resolves symlinks only for relative paths

2013-02-03 Thread Pete Wyckoff
mfaze...@szemafor.com wrote on Tue, 29 Jan 2013 09:37 +0100: > If a p4 client is configured to /p/foo which is a symlink > to /vol/bar/projects/foo, then resolving symlink, which > is done by git-p4's chdir will confuse p4: "Path > /vol/bar/projects/foo/... is not under client root /p/foo" > While

[PATCH] git p4: chdir resolves symlinks only for relative paths

2013-01-29 Thread Miklós Fazekas
[resending as plain text] If a p4 client is configured to /p/foo which is a symlink to /vol/bar/projects/foo, then resolving symlink, which is done by git-p4's chdir will confuse p4: "Path /vol/bar/projects/foo/... is not under client root /p/foo" While AltRoots in p4 client specification can be u