Re: [PATCH] git-web--browse: recognize iTerm as a GUI terminal on OS X

2013-04-03 Thread John Szakmeister
On Wed, Mar 27, 2013 at 10:43 AM, Junio C Hamano wrote: [snip] > If that approach is better than what you originally sent, then yes. > > But I do not use OS X, so you may need to pay attention to possible > complaints and comments from other Mac users on this list for a > while---there may be peop

Re: [PATCH] git-web--browse: recognize iTerm as a GUI terminal on OS X

2013-03-27 Thread Junio C Hamano
John Szakmeister writes: > Sorry about the repeat Junio, I meant to hit "Reply to All". > > On Mon, Mar 25, 2013 at 5:44 PM, Junio C Hamano wrote: > [snip] >> Your patch makes me wonder if >> >> test -n "$TERM_PROGRAM" >> >> without any SECURITYSESSIONID or explicit program name checks s

Re: [PATCH] git-web--browse: recognize iTerm as a GUI terminal on OS X

2013-03-26 Thread John Szakmeister
Sorry about the repeat Junio, I meant to hit "Reply to All". On Mon, Mar 25, 2013 at 5:44 PM, Junio C Hamano wrote: [snip] > Your patch makes me wonder if > > test -n "$TERM_PROGRAM" > > without any SECURITYSESSIONID or explicit program name checks should > suffice, though. So, after dow

Re: [PATCH] git-web--browse: recognize iTerm as a GUI terminal on OS X

2013-03-25 Thread Junio C Hamano
John Szakmeister writes: > It turns out that the presence of SECURITYSESSIONID is not sufficient > for detecting the presence of a GUI under Mac OS X. SECURITYSESSIONID > appears to only be set when the user has Screen Sharing enabled. > Disabling Screen Sharing and relaunching the shell showed

Re: [PATCH] git-web--browse: recognize iTerm as a GUI terminal on OS X

2013-03-25 Thread Christian Couder
On Mon, Mar 25, 2013 at 11:13 AM, John Szakmeister wrote: > > Here's an updated patch. Thank you for it. For what it's worth: Acked-by: Christian Couder > I also noticed that git-bisect.sh is > also trying to determine if a GUI is present by looking for > SECURITYSESSIONID as well. I wonder i

[PATCH] git-web--browse: recognize iTerm as a GUI terminal on OS X

2013-03-25 Thread John Szakmeister
It turns out that the presence of SECURITYSESSIONID is not sufficient for detecting the presence of a GUI under Mac OS X. SECURITYSESSIONID appears to only be set when the user has Screen Sharing enabled. Disabling Screen Sharing and relaunching the shell showed that the variable was missing, at l