Re: [PATCH] git-tag(1): we tag HEAD by default

2013-04-03 Thread Junio C Hamano
Thomas Rast writes: > Yann Droneaud writes: > ... >> Is there any other kind of object that can be tagged ... and what is >> the purpose of this ? > > Any object type, including tags. Signed tags of other tags probably > make sense if you want to express extra approval on top of the original >

Re: [PATCH] git-tag(1): we tag HEAD by default

2013-04-03 Thread Junio C Hamano
Thomas Rast writes: > There are some instances with the comma style: > > $ git grep ',.*::$' Documentation/*.txt > Documentation/blame-options.txt:-L ,, -L ::: > Documentation/config.txt:gitcvs.dbuser, gitcvs.dbpass:: > Documentation/config.txt:http.lowSpeedLimit, http.lowSpeedTime:: >

Re: [PATCH] git-tag(1): we tag HEAD by default

2013-04-03 Thread Thomas Rast
Yann Droneaud writes: > Hi, > > Le 03.04.2013 16:27, Thomas Rast a écrit : >> +, :: >> +The object that the new tag will refer to, usually a commit. >> +Defaults to HEAD. > > Is there any other kind of object that can be tagged ... and what is > the purpose of this ? Any object type, in

Re: [PATCH] git-tag(1): we tag HEAD by default

2013-04-03 Thread Yann Droneaud
Hi, Le 03.04.2013 16:27, Thomas Rast a écrit : The | argument is actually not explained anywhere (except implicitly in the description of an unannotated tag). Write a little explanation, in particular to cover the default. +, :: + The object that the new tag will refer to, usually a

Re: [PATCH] git-tag(1): we tag HEAD by default

2013-04-03 Thread Junio C Hamano
Thomas Rast writes: > Junio C Hamano writes: > >> Thomas Rast writes: >> >>> +, :: >>> + The object that the new tag will refer to, usually a commit. >>> + Defaults to HEAD. >> >> Shouldn't this be more like this: >> >> :: >> :: >> Your explanation here... > > Hmm, you're right

Re: [PATCH] git-tag(1): we tag HEAD by default

2013-04-03 Thread Thomas Rast
Junio C Hamano writes: > Thomas Rast writes: > >> +, :: >> +The object that the new tag will refer to, usually a commit. >> +Defaults to HEAD. > > Shouldn't this be more like this: > > :: > :: > Your explanation here... Hmm, you're right, but we seem to be fairly inconsist

Re: [PATCH] git-tag(1): we tag HEAD by default

2013-04-03 Thread Junio C Hamano
Thomas Rast writes: > The | argument is actually not explained anywhere > (except implicitly in the description of an unannotated tag). Write a > little explanation, in particular to cover the default. > > Signed-off-by: Thomas Rast > --- > > Prompted by a question on IRC about the default valu

[PATCH] git-tag(1): we tag HEAD by default

2013-04-03 Thread Thomas Rast
The | argument is actually not explained anywhere (except implicitly in the description of an unannotated tag). Write a little explanation, in particular to cover the default. Signed-off-by: Thomas Rast --- Prompted by a question on IRC about the default value. Do we actually read our own docs