Re: [PATCH] git-svn: make it play nicely with submodules

2015-01-10 Thread Ramkumar Ramachandra
Eric Wong wrote: > How portable is open on a directory? Perhaps it'd be better to > check if it's a file, first: Sure, that works; feel free to fix it up locally before committing. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.

Re: [PATCH] git-svn: make it play nicely with submodules

2015-01-10 Thread Eric Wong
Ramkumar Ramachandra wrote: > +++ b/git-svn.perl > @@ -337,6 +337,10 @@ for (my $i = 0; $i < @ARGV; $i++) { > # make sure we're always running at the top-level working directory > if ($cmd && $cmd =~ /(?:clone|init|multi-init)$/) { > $ENV{GIT_DIR} ||= ".git"; > + # catch the submodule

[PATCH] git-svn: make it play nicely with submodules

2015-01-10 Thread Ramkumar Ramachandra
It's a simple matter of opening the directory specified in the gitfile. Signed-off-by: Ramkumar Ramachandra --- git-svn.perl | 4 1 file changed, 4 insertions(+) diff --git a/git-svn.perl b/git-svn.perl index 6aa156c..8642783 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -337,6 +337,10 @