Re: [PATCH] git-submodule: respect -q for add/update

2012-09-05 Thread Jens Lehmann
Am 05.09.2012 13:42, schrieb Orgad and Raizel Shaneh: > On Tue, Sep 4, 2012 at 6:28 PM, Jens Lehmann wrote: >> >> Am 04.09.2012 09:31, schrieb Orgad Shaneh: >>> Signed-off-by: Orgad Shaneh >> >> Before the "Signed-off-by" is the place where you should have >> explained why this would be a worthwh

Re: [PATCH] git-submodule: respect -q for add/update

2012-09-05 Thread Orgad and Raizel Shaneh
On Tue, Sep 4, 2012 at 6:28 PM, Jens Lehmann wrote: > > Am 04.09.2012 09:31, schrieb Orgad Shaneh: > > Signed-off-by: Orgad Shaneh > > Before the "Signed-off-by" is the place where you should have > explained why this would be a worthwhile change ;-) > > To me this looks like you make the default

Re: [PATCH] git-submodule: respect -q for add/update

2012-09-04 Thread Jens Lehmann
Am 04.09.2012 09:31, schrieb Orgad Shaneh: > Signed-off-by: Orgad Shaneh Before the "Signed-off-by" is the place where you should have explained why this would be a worthwhile change ;-) To me this looks like you make the default noisier and require an explicit "-q" to make it quiet again. There

[PATCH] git-submodule: respect -q for add/update

2012-09-04 Thread Orgad Shaneh
Signed-off-by: Orgad Shaneh --- git-submodule.sh | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/git-submodule.sh b/git-submodule.sh index aac575e..dd57abb 100755 --- a/git-submodule.sh +++ b/git-submodule.sh @@ -266,6 +266,11 @@ cmd_add() repo=$