Re: [PATCH] git-send-email.perl: implement suggestions made by perlcritic

2013-03-27 Thread Junio C Hamano
Ramkumar Ramachandra writes: > I don't see this queued in 'pu'. Do you have any objections to the > patch, or did you just forget? I do not recall the details but I think I was expecting a re-roll updating the log message (if the original invited questions, there must have been some room for im

Re: [PATCH] git-send-email.perl: implement suggestions made by perlcritic

2013-03-27 Thread Ramkumar Ramachandra
Junio, I don't see this queued in 'pu'. Do you have any objections to the patch, or did you just forget? Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.h

Re: [PATCH] git-send-email.perl: implement suggestions made by perlcritic

2013-03-21 Thread Ramkumar Ramachandra
Junio C Hamano wrote: > Ramkumar Ramachandra writes: > >> diff --git a/git-send-email.perl b/git-send-email.perl >> index be809e5..e974b11 100755 >> --- a/git-send-email.perl >> +++ b/git-send-email.perl >> @@ -513,7 +513,7 @@ if (@alias_files and $aliasfiletype and defined >> $parse_alias{$alias

Re: [PATCH] git-send-email.perl: implement suggestions made by perlcritic

2013-03-21 Thread Junio C Hamano
Ramkumar Ramachandra writes: > diff --git a/git-send-email.perl b/git-send-email.perl > index be809e5..e974b11 100755 > --- a/git-send-email.perl > +++ b/git-send-email.perl > @@ -513,7 +513,7 @@ if (@alias_files and $aliasfiletype and defined > $parse_alias{$aliasfiletype}) { > ($sender) = exp

[PATCH] git-send-email.perl: implement suggestions made by perlcritic

2013-03-21 Thread Ramkumar Ramachandra
Running perlcritic with gentle severity reports six problems. The following lists the line numbers on which the problems occur, along with a description of the problem. This patch fixes them all. 516: Contrary to common belief, subroutine prototypes do not enable compile-time checks for proper a