Re: [PATCH] git-send-email: honor $PATH

2017-11-27 Thread Florian Klink
Support to detect sendmail binaries in windows' PATH seems a bit more complex. The separator is different, and PATHEXT would need to be considered too. I'm not even sure if having a sendmail binary in PATH on windows is something usual or if defaulting to smtp to localhost (what we currently do)

Re: [PATCH] git-send-email: honor $PATH

2017-11-19 Thread Florian Klink
On 17-11-19 10:04:58, Junio C Hamano wrote: "brian m. carlson" writes: This patch adds support for PATH, but it also removes the fixed paths. On many systems, unprivileged users don't have /usr/sbin in their PATH, and I know of no systems which provide /usr/lib as a PATH value. Therefore, it's

Re: [PATCH] git-send-email: honor $PATH

2017-11-18 Thread Junio C Hamano
"brian m. carlson" writes: > This patch adds support for PATH, but it also removes the fixed paths. > On many systems, unprivileged users don't have /usr/sbin in their PATH, > and I know of no systems which provide /usr/lib as a PATH value. > Therefore, it's possible that this change will break a

Re: [PATCH] git-send-email: honor $PATH

2017-11-18 Thread Florian Klink
This patch adds support for PATH, but it also removes the fixed paths. On many systems, unprivileged users don't have /usr/sbin in their PATH, and I know of no systems which provide /usr/lib as a PATH value. Therefore, it's possible that this change will break automatic detection of sendmail for m

Re: [PATCH] git-send-email: honor $PATH

2017-11-18 Thread brian m. carlson
On Sat, Nov 18, 2017 at 01:42:49PM +0100, Florian Klink wrote: > This will search $PATH for a sendmail binary, instead of the (previously > fixed) list of paths. > > Signed-off-by: Florian Klink > --- > Documentation/git-send-email.txt | 5 ++--- > git-send-email.perl | 3 ++- > 2 f

[PATCH] git-send-email: honor $PATH

2017-11-18 Thread Florian Klink
This will search $PATH for a sendmail binary, instead of the (previously fixed) list of paths. Signed-off-by: Florian Klink --- Documentation/git-send-email.txt | 5 ++--- git-send-email.perl | 3 ++- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/git-s